Re: [PR PATCH] [Updated] New package: vmware-horizon-client-2303

[abenson <abenson@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 680 bytes --]

There is an updated pull request by abenson against master on the void-packages repository

https://github.com/abenson/void-packages np_vmwarehorizon
https://github.com/void-linux/void-packages/pull/43564

New package: vmware-horizon-client-2303
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


#### Local build testing
- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/43564.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-np_vmwarehorizon-43564.patch --]
[-- Type: text/x-diff, Size: 5929 bytes --]

From be98011816f64c477d633409649e97757b6539d3 Mon Sep 17 00:00:00 2001
From: Andrew Benson <abenson@gmail.com>
Date: Thu, 20 Apr 2023 20:41:43 -0500
Subject: [PATCH 1/2] New package: libudev0-shim-1

---
 common/shlibs                  |  1 +
 srcpkgs/libudev0-shim/template | 21 +++++++++++++++++++++
 2 files changed, 22 insertions(+)
 create mode 100644 srcpkgs/libudev0-shim/template

diff --git a/common/shlibs b/common/shlibs
index 0b05cd99d6b3..457f56f34ca3 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -217,6 +217,7 @@ libpcrecpp.so.0 libpcrecpp-7.8_1
 libgirepository-gimarshallingtests-1.0.so libgirepository-1.30_1
 libgirepository-everything-1.0.so libgirepository-1.30_1
 libgirepository-1.0.so.1 libgirepository-1.30_1
+libudev.so.0 libudev0-shim-1_1
 libudev.so.1 eudev-libudev-1.6_1
 libgudev-1.0.so.0 libgudev-230_1
 libumockdev.so.0 libumockdev-0.17.6_1
diff --git a/srcpkgs/libudev0-shim/template b/srcpkgs/libudev0-shim/template
new file mode 100644
index 000000000000..df496604a160
--- /dev/null
+++ b/srcpkgs/libudev0-shim/template
@@ -0,0 +1,21 @@
+# Template file for 'libudev0-shim'
+pkgname=libudev0-shim
+version=1
+revision=1
+build_style=gnu-makefile
+makedepends="eudev-libudev-devel"
+short_desc="Compability library shim for libudev.so.0"
+maintainer="Andrew Benson <abenson@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/archlinux/libudev0-shim"
+distfiles="https://github.com/archlinux/libudev0-shim/archive/v${version}.tar.gz"
+checksum=24a1072fa437935d6c4e1d9c1ce84f4ad1d7be45026f6ee7b0b3d77ec0f66e3c
+
+do_build() {
+	unset LDFLAGS
+	make
+}
+
+do_install() {
+	vinstall libudev.so.0.0.9999 0755 usr/lib libudev.so.0
+}

From 026026deda8d5cfa33224e3d3230e4562e6db940 Mon Sep 17 00:00:00 2001
From: Andrew Benson <abenson@gmail.com>
Date: Thu, 20 Apr 2023 20:31:43 -0500
Subject: [PATCH 2/2] New package: vmware-horizon-client-2303

---
 srcpkgs/vmware-horizon-client-smartcard       |  1 +
 .../vmware-horizon-client/files/ftscanhvd/run |  5 ++
 .../vmware-horizon-client/files/ftsprhvd/run  |  5 ++
 .../files/vmware-USBArbitrator/run            |  5 ++
 srcpkgs/vmware-horizon-client/template        | 58 +++++++++++++++++++
 5 files changed, 74 insertions(+)
 create mode 120000 srcpkgs/vmware-horizon-client-smartcard
 create mode 100755 srcpkgs/vmware-horizon-client/files/ftscanhvd/run
 create mode 100755 srcpkgs/vmware-horizon-client/files/ftsprhvd/run
 create mode 100755 srcpkgs/vmware-horizon-client/files/vmware-USBArbitrator/run
 create mode 100644 srcpkgs/vmware-horizon-client/template

diff --git a/srcpkgs/vmware-horizon-client-smartcard b/srcpkgs/vmware-horizon-client-smartcard
new file mode 120000
index 000000000000..232d869ed0ac
--- /dev/null
+++ b/srcpkgs/vmware-horizon-client-smartcard
@@ -0,0 +1 @@
+vmware-horizon-client
\ No newline at end of file
diff --git a/srcpkgs/vmware-horizon-client/files/ftscanhvd/run b/srcpkgs/vmware-horizon-client/files/ftscanhvd/run
new file mode 100755
index 000000000000..f5fe8ffcf240
--- /dev/null
+++ b/srcpkgs/vmware-horizon-client/files/ftscanhvd/run
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+exec 2>&1
+
+exec /usr/lib/vmware/view/bin/ftscanhvd -D
diff --git a/srcpkgs/vmware-horizon-client/files/ftsprhvd/run b/srcpkgs/vmware-horizon-client/files/ftsprhvd/run
new file mode 100755
index 000000000000..136d93fc1c46
--- /dev/null
+++ b/srcpkgs/vmware-horizon-client/files/ftsprhvd/run
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+exec 2>&1
+
+exec /usr/lib/vmware/view/bin/ftsprhvd -D
diff --git a/srcpkgs/vmware-horizon-client/files/vmware-USBArbitrator/run b/srcpkgs/vmware-horizon-client/files/vmware-USBArbitrator/run
new file mode 100755
index 000000000000..ea9654cd8683
--- /dev/null
+++ b/srcpkgs/vmware-horizon-client/files/vmware-USBArbitrator/run
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+exec 2>&1
+
+exec chpst -P /usr/bin/vmware-usbarbitrator
diff --git a/srcpkgs/vmware-horizon-client/template b/srcpkgs/vmware-horizon-client/template
new file mode 100644
index 000000000000..629a22780d54
--- /dev/null
+++ b/srcpkgs/vmware-horizon-client/template
@@ -0,0 +1,58 @@
+# Template file for 'vmware-horizon-client'
+pkgname=vmware-horizon-client
+version=2303
+revision=1
+_build1=8.9.0
+_build2=21435420
+_cart="CART24FQ1_LIN_${version}"
+archs="x86_64"
+short_desc="VMware Horizon virtual desktop client"
+maintainer="Andrew Benson <abenson@gmail.com>"
+license="custom:Proprietary"
+homepage="https://www.vmware.com/go/viewclients"
+distfiles="https://download3.vmware.com/software/${_cart}_TARBALL/VMware-Horizon-Client-Linux-${version}-${_build1}-${_build2}.tar.gz"
+checksum=a4dcc6afc0be7641e10e922ccbbab0a10adbf8f2a83e4b5372dfba095091fb78
+repository=nonfree
+restricted=yes
+nopie=yes
+
+do_install() {
+	# Extract main components and copy into place
+	vmkdir usr
+	for _bundle in Client html5mmr PCoIP USB integratedPrinting scannerClient serialportClient; do
+		bsdtar xf "x64/VMware-Horizon-${_bundle}-${version}-${_build1}-${_build2}.x64.tar.gz"
+		vcopy "VMware-Horizon-${_bundle}-${version}-${_build1}-${_build2}.x64/*" usr/
+	done
+
+	vmkdir etc
+	mv ${DESTDIR}/usr/vmware ${DESTDIR}/etc
+
+	# Replace shipped libav with ours
+	for LIB in 'libavcodec.so.59' 'libavutil.so.57'; do
+		find "${DESTDIR}/usr/lib/vmware/view/" -name "${LIB}" -exec ln -sf "/usr/lib/${LIB}" {} \;
+	done
+
+	# Allow for use of pkcs11 smartcards
+	vmkdir usr/lib/vmware/view/pkcs11
+	ln -sf /usr/lib/pkcs11/opensc-pkcs11.so ${DESTDIR}/usr/lib/vmware/view/pkcs11/libopenscpkcs11.so
+
+	vsv ftscanhvd
+	vsv ftsprhvd
+	vsv vmware-USBArbitrator
+
+	vlicense ${DESTDIR}/usr/doc/open_source_licenses.txt
+
+	rm -rf ${DESTDIR}/usr/README  \
+	       ${DESTDIR}/usr/doc     \
+	       ${DESTDIR}/usr/patches \
+	       ${DESTDIR}/usr/init.d  \
+	       ${DESTDIR}/usr/systemd
+}
+
+vmware-horizon-client-smartcard_package() {
+	short_desc+=" - pkcs11 support"
+	depends="opensc-pkcs11"
+	pkg_install() {
+		vmove usr/lib/vmware/view/pkcs11
+	}
+}