Re: [PR PATCH] [Closed]: lame: fix ID3 tags on musl

[sgn <sgn@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1522 bytes --]

There's a closed pull request on the void-packages repository

lame: fix ID3 tags on musl
https://github.com/void-linux/void-packages/pull/43550

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

musl's iconv does not support transliterations causing `lame` to fail to write most of the ID3 tags.

I have modified the code so that it only does transliteration if the host libc is glibc. I don't know whether there are any other iconv implementations which support this, if so, please let me know and I can try to add them, although for Void's purposes it's needless at the moment.

I have not attempted to submit the patch upstream as it seems inactive, I might try to do so later.

#### Testing the changes
- I tested the changes in this PR: **YES** (on musl)

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64