Github messages for voidlinux
 help / color / mirror / Atom feed
From: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Closed]: pinebookpro-uboot: fixed kernel.d script
Date: Tue, 25 Apr 2023 03:53:30 +0200	[thread overview]
Message-ID: <20230425015330.VZG5i_J48SvRoCh2w6tSX51b8Fn6Sv1lKytBLItmT80@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40128@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1108 bytes --]

There's a closed pull request on the void-packages repository

pinebookpro-uboot: fixed kernel.d script
https://github.com/void-linux/void-packages/pull/40128

Description:
The original (rev. 2) does not work e. g. with encrypted root and also fails if there are certain commented out lines in /etc/fstab. This proposed version fixes both issues. If the / line in fstab does not include UUID, the device is taken directly from fstab.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (arm64-glibc)
- This package is specifically designed for Pinebook Pro which only employs arm64.

      parent reply	other threads:[~2023-04-25  1:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-23 15:16 [PR PATCH] " strec007
2022-10-27 23:54 ` classabbyamp
2022-10-28 10:00 ` [PR REVIEW] " sgn
2022-10-28 10:00 ` sgn
2022-10-28 10:47 ` strec007
2022-10-28 10:52 ` strec007
2022-10-28 14:28 ` CameronNemo
2022-10-28 14:30 ` CameronNemo
2023-01-10 14:05 ` [PR REVIEW] " strec007
2023-04-11  1:51 ` github-actions
2023-04-25  1:53 ` github-actions [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230425015330.VZG5i_J48SvRoCh2w6tSX51b8Fn6Sv1lKytBLItmT80@z \
    --to=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).