Github messages for voidlinux
 help / color / mirror / Atom feed
From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: python3-Babel: update to 2.12.1.
Date: Tue, 25 Apr 2023 17:37:30 +0200	[thread overview]
Message-ID: <20230425153730.3HOkwfI0QqPXx7ZYJMirf_vMPmOJuSWrpvreLeOkqEo@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43497@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/43497#issuecomment-1522014357

Comment:
I would argue that the new behaviour is more correct :D 

Anyway, this could fix the test:
```diff
diff --git a/srcpkgs/python3-Babel/template b/srcpkgs/python3-Babel/template
index 46530ba596e..9255e8537f4 100644
--- a/srcpkgs/python3-Babel/template
+++ b/srcpkgs/python3-Babel/template
@@ -4,8 +4,7 @@ version=2.12.1
 revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3-pytz"
-checkdepends="python3-pytest python3-pytz python3-freezegun"
+checkdepends="python3-pytest python3-freezegun faketime"
 short_desc="Tools for internationalizing Python applications (Python3)"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-3-Clause"
@@ -14,6 +13,14 @@ changelog="https://raw.githubusercontent.com/python-babel/babel/master/CHANGES.r
 distfiles="${PYPI_SITE}/B/Babel/Babel-${version}.tar.gz"
 checksum=cc2d99999cd01d44420ae725a21c9e3711b3aadc7976d6147f622d8581963455
 
+do_check() {
+	# If you see this is hanging, remove faketime
+	# it has problem with python's time.sleep
+	LD_PRELOAD=/usr/lib/faketime/libfaketime.so.1 \
+		FAKETIME="@2023-01-01 00:00:00" \
+		python3 -m pytest
+}
+
 post_install() {
 	vlicense LICENSE
 	# for compatibility
```

The 998 patch is no longer needed, too.
http://ix.io/4ugi

  parent reply	other threads:[~2023-04-25 15:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-17 18:23 [PR PATCH] " tornaria
2023-04-24  0:32 ` tornaria
2023-04-25 13:13 ` tornaria
2023-04-25 15:37 ` sgn [this message]
2023-04-25 15:53 ` [PR PATCH] [Updated] " tornaria
2023-04-25 15:54 ` tornaria
2023-04-25 21:23 ` [PR PATCH] [Updated] " tornaria
2023-04-27  2:37 ` tornaria
2023-04-28 20:28 ` tornaria
2023-04-28 21:39 ` [PR PATCH] [Merged]: " sgn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230425153730.3HOkwfI0QqPXx7ZYJMirf_vMPmOJuSWrpvreLeOkqEo@z \
    --to=sgn@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).