Re: [PR PATCH] [Updated] vivaldi: support user flags, adopt

[classabbyamp <classabbyamp@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 794 bytes --]

There is an updated pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages vivaldi
https://github.com/void-linux/void-packages/pull/43728

vivaldi: support user flags, adopt
will now read the contents of `$XDG_CONFIG_HOME/vivaldi-stable.conf` and pass that to the underlying binary

patch comes from arch

for example, to force `prefers-color-scheme: dark` and work on wayland:
```
$ cat ~/.config/vivaldi-stable.conf
--force-dark-mode --ozone-platform-hint=auto
```

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**



A patch file from https://github.com/void-linux/void-packages/pull/43728.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vivaldi-43728.patch --]
[-- Type: text/x-diff, Size: 4058 bytes --]

From f3c926b17dc09b22be8cfbb295483471bf965612 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Wed, 3 May 2023 15:08:42 -0400
Subject: [PATCH] vivaldi: update to 6.0.2979.18, support user flags, adopt.

will now read the contents of `$XDG_CONFIG_HOME/vivaldi-stable.conf` and
pass that to the underlying binary

patch comes from arch

for example, to force `prefers-color-scheme: dark` and work on wayland:
```
$ cat ~/.config/vivaldi-stable.conf
--force-dark-mode --ozone-platform-hint=auto
```

missing dependencies libnotify and xdg-utils also added
---
 .../vivaldi/patches/support-user-flags.patch  | 37 +++++++++++++++++++
 srcpkgs/vivaldi/template                      | 12 +++---
 2 files changed, 43 insertions(+), 6 deletions(-)
 create mode 100644 srcpkgs/vivaldi/patches/support-user-flags.patch

diff --git a/srcpkgs/vivaldi/patches/support-user-flags.patch b/srcpkgs/vivaldi/patches/support-user-flags.patch
new file mode 100644
index 000000000000..5d3ef3bbe4b0
--- /dev/null
+++ b/srcpkgs/vivaldi/patches/support-user-flags.patch
@@ -0,0 +1,37 @@
+From 68c2dec905a7c88895c458dd40708ab9989385cf Mon Sep 17 00:00:00 2001
+From: BlackEagle <ike.devolder@gmail.com>
+Date: Wed, 19 Jan 2022 20:57:58 +0100
+Subject: [PATCH] add support for user flags
+
+Signed-off-by: BlackEagle <ike.devolder@gmail.com>
+---
+ opt/vivaldi/vivaldi | 9 ++++++++-
+ 1 file changed, 8 insertions(+), 1 deletion(-)
+
+diff --git a/opt/vivaldi/vivaldi b/opt/vivaldi/vivaldi
+index 5b5f1bf..8e95859 100755
+--- a/opt/vivaldi/vivaldi
++++ b/opt/vivaldi/vivaldi
+@@ -53,6 +53,13 @@ export CHROME_VERSION_EXTRA="stable"
+ # We don't want bug-buddy intercepting our crashes. http://crbug.com/24120
+ export GNOME_DISABLE_CRASH_DIALOG=SET_BY_GOOGLE_CHROME
+ 
++# Allow users to override command-line options
++XDG_CONFIG_HOME=${XDG_CONFIG_HOME:-$HOME/.config}
++VIVALDI_USER_FLAGS=""
++if [[ -f "$XDG_CONFIG_HOME/vivaldi-$CHROME_VERSION_EXTRA.conf" ]]; then
++   VIVALDI_USER_FLAGS="$(cat "$XDG_CONFIG_HOME/vivaldi-$CHROME_VERSION_EXTRA.conf")"
++fi
++
+ # Sanitize std{in,out,err} because they'll be shared with untrusted child
+ # processes (http://crbug.com/376567).
+ exec < /dev/null
+@@ -60,4 +67,4 @@ exec > >(exec cat)
+ exec 2> >(exec cat >&2)
+ 
+ # Note: exec -a below is a bashism.
+-exec -a "$0" "$HERE/vivaldi-bin" "$@"
++exec -a "$0" "$HERE/vivaldi-bin" $VIVALDI_USER_FLAGS "$@"
+-- 
+2.34.1
+
diff --git a/srcpkgs/vivaldi/template b/srcpkgs/vivaldi/template
index 7e4d4e8ab554..970fd3838d95 100644
--- a/srcpkgs/vivaldi/template
+++ b/srcpkgs/vivaldi/template
@@ -1,12 +1,12 @@
 # Template file for 'vivaldi'
 pkgname=vivaldi
-version=6.0.2979.15
+version=6.0.2979.18
 revision=1
 _release=1
 archs="x86_64 aarch64 armv7l"
-depends="desktop-file-utils hicolor-icon-theme xz"
+depends="desktop-file-utils hicolor-icon-theme xz libnotify xdg-utils"
 short_desc="Advanced browser made with the power user in mind"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="classabbyamp <void@placeviolette.net>"
 license="custom:Proprietary"
 homepage="https://vivaldi.com"
 repository=nonfree
@@ -16,15 +16,15 @@ skiprdeps="/opt/vivaldi/libqt5_shim.so"
 case "$XBPS_TARGET_MACHINE" in
 x86_64)
 	distfiles="https://downloads.vivaldi.com/stable/vivaldi-stable_${version}-${_release}_amd64.deb"
-	checksum=bef374031acaa2da61608a64c8e28706010e42d1782ef601575701e7dd4809b7
+	checksum=baa8572fb9277661a838e6a5c90ea6571441de4f0bd75509cc00c29cd6a48fae
 	;;
 aarch64)
 	distfiles="https://downloads.vivaldi.com/stable/vivaldi-stable_${version}-${_release}_arm64.deb"
-	checksum=eab113c5e131b47c56aca14ed0c1f38cb82768751e44456ab0e07ddbae2366bf
+	checksum=4b76f49a65ac42158328fcf7e06cdbe74abec00511005344b7a22f0aaa3c08cb
 	;;
 armv7l)
 	distfiles="https://downloads.vivaldi.com/stable/vivaldi-stable_${version}-${_release}_armhf.deb"
-	checksum=da92a980b0b8c7c6f96f5a56204e3bff72d333c17131c6f8f3c990a9ba84c9d3
+	checksum=7ddd07ade52ef79aa41a3467737620b941491482250b03a7f06f11de2c71ec1e
 	;;
 *)
 	broken="No distfiles available for this target"