Github messages for voidlinux
 help / color / mirror / Atom feed
From: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Closed]: New package: libguestfs-tools 1.48.0
Date: Fri, 05 May 2023 03:49:03 +0200	[thread overview]
Message-ID: <20230505014903.0qMESpLdfNIlrtHNAy0ebQKjWGm6Phl_4dZb2C_CnJI@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-37416@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 2435 bytes --]

There's a closed pull request on the void-packages repository

New package: libguestfs-tools 1.48.0
https://github.com/void-linux/void-packages/pull/37416

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

perl-Locale-TextDomain is only introduced for the script in perl.

libguestfs-tools is not technically now, some time ago it was part of libguestfs.    Some tools were split into their own packages before libguestfs 1.45.2 and split into this package, see:

    https://github.com/libguestfs/libguestfs/commit/733d2182b64df7abc5c5cd7d78177baa6079628c

Without this package, important tools like virt-sysprep were not provided at all.

The package is guestfs-tools but all other distributions align the package name with libguestfs.

Note that the test suite is very resource-intensive, needs to download 100+MB of images, and runs VMs for several of the tests for several minutes, which I don't think are reasonable for commit-time tests.  They have been successful otherwise, apart from test-virt-sysprep-script.sh, which has been disabled.

Part of the test suite is downloading a test VM image, which is roughly the purpose of the `update-libguestfs-appliance` script in  the base libguestfs package, however, it's not designed to run as a normal user in the chroot test pass.

(It also refers to an image which is no longer available, but I'm not sure what's the best approach to make it work, as it's only needed for the test suite, which is not nice at all to be run in a CI environment)

Perhaps to be coordinated with @Hoshpak (I don't insist staying the maintainer for these new entries, but don't mind it either)

---

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- Could not test any other archs, will check the CI


      parent reply	other threads:[~2023-05-05  1:49 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-05 19:14 [PR PATCH] " chexum
2022-06-05 19:19 ` [PR PATCH] [Updated] " chexum
2022-06-09  5:17 ` chexum
2022-06-26 16:59 ` [PR PATCH] [Updated] New package: " chexum
2022-06-27 11:28 ` chexum
2022-06-27 22:22 ` Duncaen
2022-06-27 22:45 ` [PR REVIEW] " Duncaen
2022-06-27 22:46 ` Duncaen
2022-06-27 22:46 ` Duncaen
2022-06-27 22:48 ` Duncaen
2022-06-29 16:04 ` chexum
2022-06-29 16:27 ` [PR REVIEW] " chexum
2022-06-29 16:50 ` [PR PATCH] [Updated] " chexum
2022-06-29 16:51 ` [PR REVIEW] " chexum
2022-06-29 17:02 ` Duncaen
2022-07-03 14:51 ` chexum
2022-10-02  2:15 ` github-actions
2022-10-09 18:56 ` chexum
2023-01-09  1:58 ` github-actions
2023-01-18 18:09 ` chexum
2023-04-20  1:51 ` github-actions
2023-05-05  1:49 ` github-actions [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230505014903.0qMESpLdfNIlrtHNAy0ebQKjWGm6Phl_4dZb2C_CnJI@z \
    --to=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).