Github messages for voidlinux
 help / color / mirror / Atom feed
From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] mdcat: install completions and manpage for mdless.
Date: Thu, 11 May 2023 04:15:38 +0200	[thread overview]
Message-ID: <20230511021538.-QOcTjNMf-p9V5vbTsNr7HELt_oh7ZiW9ie4ZN3tLwE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43771@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/43771#discussion_r1190568755

Comment:
Nope, I don't think it make sense, its `.TH` is `MDCAT`, its `.SH "NAME"`  is `mdcat`, upstream should change like this:
```diff
30c30
< mdcat \- render CommonMark Markdown to text terminals
---
> mdcat, mdless \- render CommonMark Markdown to text terminals
```

  parent reply	other threads:[~2023-05-11  2:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-06 19:01 [PR PATCH] " mhmdanas
2023-05-06 19:05 ` [PR REVIEW] " classabbyamp
2023-05-06 19:11 ` mhmdanas
2023-05-11  2:15 ` sgn [this message]
2023-05-19 20:05 ` [PR PATCH] [Updated] " mhmdanas
2023-05-21 18:16 ` [PR REVIEW] mdcat: install completions " mhmdanas
2023-05-26 13:18 ` [PR PATCH] [Merged]: " leahneukirchen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230511021538.-QOcTjNMf-p9V5vbTsNr7HELt_oh7ZiW9ie4ZN3tLwE@z \
    --to=sgn@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).