Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] coin3: disable check_cxx_source_compiles, fix freecad for wayland
@ 2022-05-07 22:19 hervyqa
  2022-05-08  1:02 ` [PR REVIEW] " sgn
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: hervyqa @ 2022-05-07 22:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 950 bytes --]

There is a new pull request by hervyqa against master on the void-packages repository

https://github.com/hervyqa/void-packages coin3
https://github.com/void-linux/void-packages/pull/37027

coin3: disable check_cxx_source_compiles, fix freecad for wayland
- fix FreeCAD for wayland (#14626). patch from:
  https://forum.freecadweb.org/viewtopic.php?p=354412&sid=85ff490ba28d18686795d961cf062754#p354412
- previously @paper42 using Gnome Wayland also had the same error.
  https://github.com/void-linux/void-packages/issues/30515#issuecomment-826906957

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)

![Screenshot_20220508_051800](https://user-images.githubusercontent.com/45872139/167273542-692606d3-04db-46cf-9c22-c5b24853ad24.png)



A patch file from https://github.com/void-linux/void-packages/pull/37027.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-coin3-37027.patch --]
[-- Type: text/x-diff, Size: 2108 bytes --]

From 6e57761e964730af7e5ffa104f588e4b9e92118e Mon Sep 17 00:00:00 2001
From: Hervy Qurrotul Ainur Rozi <hervyqa@pm.me>
Date: Sun, 8 May 2022 04:38:03 +0700
Subject: [PATCH] coin3: disable check_cxx_source_compiles, fix freecad for
 wayland

- fix FreeCAD for wayland (#14626). patch from:
  https://forum.freecadweb.org/viewtopic.php?p=354412&sid=85ff490ba28d18686795d961cf062754#p354412
- previously @paper42 using Gnome Wayland also had the same error.
  https://github.com/void-linux/void-packages/issues/30515#issuecomment-826906957
---
 .../disable-check_cxx_source_compiles.patch   | 20 +++++++++++++++++++
 srcpkgs/coin3/template                        |  2 +-
 2 files changed, 21 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/coin3/patches/disable-check_cxx_source_compiles.patch

diff --git a/srcpkgs/coin3/patches/disable-check_cxx_source_compiles.patch b/srcpkgs/coin3/patches/disable-check_cxx_source_compiles.patch
new file mode 100644
index 000000000000..adb754d04cdd
--- /dev/null
+++ b/srcpkgs/coin3/patches/disable-check_cxx_source_compiles.patch
@@ -0,0 +1,20 @@
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -586,11 +586,11 @@ if(NOT (HAVE_WGL OR HAVE_AGL OR HAVE_CGL
+     list(APPEND COIN_TARGET_LINK_LIBRARIES OpenGL::GLX)
+   endif()
+   set(CMAKE_REQUIRED_LIBRARIES ${COIN_TARGET_LINK_LIBRARIES})
+-  check_cxx_source_compiles("
+-    #include <GL/gl.h>
+-    #include <GL/glx.h>
+-    int main() { (void)glXChooseVisual(0L, 0, 0L); glEnd(); return 0; }
+-  " HAVE_GLX)
++#  check_cxx_source_compiles("
++#    #include <GL/gl.h>
++#    #include <GL/glx.h>
++#    int main() { (void)glXChooseVisual(0L, 0, 0L); glEnd(); return 0; }
++#  " HAVE_GLX)
+ endif()
+
+ # Checks specific OpenGL configurations
+
diff --git a/srcpkgs/coin3/template b/srcpkgs/coin3/template
index 2130c0b8b263..4a6ab27df272 100644
--- a/srcpkgs/coin3/template
+++ b/srcpkgs/coin3/template
@@ -1,7 +1,7 @@
 # Template file for 'coin3'
 pkgname=coin3
 version=4.0.0
-revision=2
+revision=3
 wrksrc="coin-Coin-${version}"
 build_style=cmake
 configure_args="-DCMAKE_INSTALL_INCLUDEDIR=include/Coin3

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] coin3: disable check_cxx_source_compiles, fix freecad for wayland
  2022-05-07 22:19 [PR PATCH] coin3: disable check_cxx_source_compiles, fix freecad for wayland hervyqa
@ 2022-05-08  1:02 ` sgn
  2022-05-08  2:10 ` hervyqa
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: sgn @ 2022-05-08  1:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/37027#discussion_r867419827

Comment:
This is assuming platform doesn't `HAVE_GLX`
I don't know anything about coin3 or freecad, but commit message is bogus.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] coin3: disable check_cxx_source_compiles, fix freecad for wayland
  2022-05-07 22:19 [PR PATCH] coin3: disable check_cxx_source_compiles, fix freecad for wayland hervyqa
  2022-05-08  1:02 ` [PR REVIEW] " sgn
@ 2022-05-08  2:10 ` hervyqa
  2022-05-08  8:08 ` hervyqa
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: hervyqa @ 2022-05-08  2:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New review comment by hervyqa on void-packages repository

https://github.com/void-linux/void-packages/pull/37027#discussion_r867423977

Comment:
any suggestions I should change to make the commit better?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] coin3: disable check_cxx_source_compiles, fix freecad for wayland
  2022-05-07 22:19 [PR PATCH] coin3: disable check_cxx_source_compiles, fix freecad for wayland hervyqa
  2022-05-08  1:02 ` [PR REVIEW] " sgn
  2022-05-08  2:10 ` hervyqa
@ 2022-05-08  8:08 ` hervyqa
  2022-05-09 22:42 ` hervyqa
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: hervyqa @ 2022-05-08  8:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

New review comment by hervyqa on void-packages repository

https://github.com/void-linux/void-packages/pull/37027#discussion_r867452631

Comment:
> This is assuming platform doesn't `HAVE_GLX`

Yes. Coin works without glx for FreeCAD probably because the functionality is not needed by FreeCAD and Coin has a dummy implementation.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: coin3: disable check_cxx_source_compiles, fix freecad for wayland
  2022-05-07 22:19 [PR PATCH] coin3: disable check_cxx_source_compiles, fix freecad for wayland hervyqa
                   ` (2 preceding siblings ...)
  2022-05-08  8:08 ` hervyqa
@ 2022-05-09 22:42 ` hervyqa
  2022-05-09 22:43 ` [PR PATCH] [Closed]: " hervyqa
  2023-05-17 13:56 ` superiums
  5 siblings, 0 replies; 7+ messages in thread
From: hervyqa @ 2022-05-09 22:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]

New comment by hervyqa on void-packages repository

https://github.com/void-linux/void-packages/pull/37027#issuecomment-1121654244

Comment:
Fix. Next release 0.20 will support wayland.

https://github.com/FreeCAD/FreeCAD/issues/6068#issuecomment-1121129958

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Closed]: coin3: disable check_cxx_source_compiles, fix freecad for wayland
  2022-05-07 22:19 [PR PATCH] coin3: disable check_cxx_source_compiles, fix freecad for wayland hervyqa
                   ` (3 preceding siblings ...)
  2022-05-09 22:42 ` hervyqa
@ 2022-05-09 22:43 ` hervyqa
  2023-05-17 13:56 ` superiums
  5 siblings, 0 replies; 7+ messages in thread
From: hervyqa @ 2022-05-09 22:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 801 bytes --]

There's a closed pull request on the void-packages repository

coin3: disable check_cxx_source_compiles, fix freecad for wayland
https://github.com/void-linux/void-packages/pull/37027

Description:
- fix FreeCAD for wayland (#14626). patch from:
  https://forum.freecadweb.org/viewtopic.php?p=354412&sid=85ff490ba28d18686795d961cf062754#p354412
- previously @paper42 using Gnome Wayland also had the same error.
  https://github.com/void-linux/void-packages/issues/30515#issuecomment-826906957

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)

![Screenshot_20220508_051800](https://user-images.githubusercontent.com/45872139/167273542-692606d3-04db-46cf-9c22-c5b24853ad24.png)



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: coin3: disable check_cxx_source_compiles, fix freecad for wayland
  2022-05-07 22:19 [PR PATCH] coin3: disable check_cxx_source_compiles, fix freecad for wayland hervyqa
                   ` (4 preceding siblings ...)
  2022-05-09 22:43 ` [PR PATCH] [Closed]: " hervyqa
@ 2023-05-17 13:56 ` superiums
  5 siblings, 0 replies; 7+ messages in thread
From: superiums @ 2023-05-17 13:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]

New comment by superiums on void-packages repository

https://github.com/void-linux/void-packages/pull/37027#issuecomment-1551446261

Comment:
i'm on 0.20.2

issue still exists.
freecad crash while open or create a project.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-05-17 13:56 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-07 22:19 [PR PATCH] coin3: disable check_cxx_source_compiles, fix freecad for wayland hervyqa
2022-05-08  1:02 ` [PR REVIEW] " sgn
2022-05-08  2:10 ` hervyqa
2022-05-08  8:08 ` hervyqa
2022-05-09 22:42 ` hervyqa
2022-05-09 22:43 ` [PR PATCH] [Closed]: " hervyqa
2023-05-17 13:56 ` superiums

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).