Github messages for voidlinux
 help / color / mirror / Atom feed
From: RoundDuckKira <RoundDuckKira@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package libXnvctrl-devel and a change in MangoHud to depend on it, so that Nvidia cards will be detected on MangoHud
Date: Tue, 23 May 2023 01:54:49 +0200	[thread overview]
Message-ID: <20230522235449.ShKl6iUzQ6HVxjOx-0aGDTjMd0h-v9kwf2x8_tdLG1U@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-44028@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1282 bytes --]

New comment by RoundDuckKira on void-packages repository

https://github.com/void-linux/void-packages/pull/44028#issuecomment-1558205149

Comment:
> Yeah, you might have to switch to a new branch and open a new PR. I remember things get kind of wonky if you try to force push to update this.
> 
> You'll need to rebase and get rid of that merge commit. Also, you'll need to move all of the changes to the `libXnvctrl(-devel?)` to one commit and the changes to `MangoHud` to another. Also, `libXnvctrl` package should be a "New package:..." commit and `-devel` split off form it and things be added to `common/shlibs` like other libraries.

Ah alright, the main reason I didn't just name it libXnvctrl is because it is just a development library package, I tried to separate the two with a devel and non devel version and xbps-src warned me that .so and .a files should be in a -devel package, so instead I'll just wholesale rename it to just libXnvctrl unless you say something otherwise and that I should split the .h files and the .so and .a files into their own separate packages.

Also how do I do this, how do I push changes into basically a branch within my repo rather than push to master? When I did git push, git pushed to master instead of to my MangoHud branch. :/

  parent reply	other threads:[~2023-05-22 23:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-22  8:46 [PR PATCH] " RoundDuckKira
2023-05-22  9:10 ` [PR PATCH] [Updated] " RoundDuckKira
2023-05-22  9:27 ` hervyqa
2023-05-22 10:19 ` RoundDuckKira
2023-05-22 10:20 ` RoundDuckKira
2023-05-22 11:44 ` abenson
2023-05-22 23:54 ` RoundDuckKira [this message]
2023-05-23 16:40 ` RoundDuckKira
2023-05-23 16:40 ` [PR PATCH] [Closed]: " RoundDuckKira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230522235449.ShKl6iUzQ6HVxjOx-0aGDTjMd0h-v9kwf2x8_tdLG1U@z \
    --to=roundduckkira@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).