[PR PATCH] Tuba: update to 0.3.2

[PR PATCH] Tuba: update to 0.3.2

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

There is a new pull request by chrysos349 against master on the void-packages repository

https://github.com/chrysos349/void-packages Tuba
https://github.com/void-linux/void-packages/pull/44024

Tuba: update to 0.3.2
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-LIBC)

A patch file from https://github.com/void-linux/void-packages/pull/44024.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-Tuba-44024.patch --]
[-- Type: text/x-diff, Size: 1516 bytes --]

From 84fdf7973a2a5027bf325ea332c913072118f623 Mon Sep 17 00:00:00 2001
From: chrysos349 <chrysostom349@gmail.com>
Date: Mon, 22 May 2023 05:32:53 +0300
Subject: [PATCH] Tuba: update to 0.3.2

---
 srcpkgs/Tuba/template | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/Tuba/template b/srcpkgs/Tuba/template
index fc2974bde2e0..3df3485ffa91 100644
--- a/srcpkgs/Tuba/template
+++ b/srcpkgs/Tuba/template
@@ -1,14 +1,21 @@
 # Template file for 'Tuba'
 pkgname=Tuba
-version=0.2.0
+version=0.3.2
 revision=1
 build_style=meson
 configure_args="-Ddistro=true"
-hostmakedepends="pkg-config gettext desktop-file-utils vala glib-devel"
-makedepends="libadwaita-devel libgee-devel libsecret-devel gtksourceview5-devel"
+hostmakedepends="desktop-file-utils gettext pkg-config"
+makedepends="gtksourceview5-devel libadwaita-devel libgee-devel libsecret-devel
+ libwebp-devel"
+depends="webp-pixbuf-loader"
+checkdepends="appstream-glib"
 short_desc="Browse the fediverse"
 maintainer="Michal Vasilek <michal@vasilek.cz>"
 license="GPL-3.0-only"
-homepage="https://tuba.geopjr.dev/"
-distfiles="https://github.com/GeopJr/Tuba/archive/refs/tags/v${version}.tar.gz"
-checksum=c698206bbbd06a1ce5a6e8cc9e6590411dc1cce1dde87fb0e34d8e35432ee2b1
+homepage="https://github.com/GeopJr/Tuba"
+distfiles="${homepage}/archive/v${version}.tar.gz"
+checksum=1458b343f069efca00b0b5da49b9eb4b529e49de3d701da06d9529828be19cf9
+
+post_install() {
+	ln -s dev.geopjr.Tuba ${DESTDIR}/usr/bin/tuba
+}

Re: [PR REVIEW] Tuba: update to 0.3.2

[paper42]

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/44024#discussion_r1201706840

Comment:
please don't randomly change the order, just add or remove what's necessary 

Re: [PR REVIEW] Tuba: update to 0.3.2

[paper42]

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/44024#discussion_r1201708018

Comment:
why?

Re: [PR REVIEW] Tuba: update to 0.3.2

[paper42]

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/44024#discussion_r1201707398

Comment:
no, revert to the previous version

Re: [PR PATCH] [Updated] Tuba: update to 0.3.2

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

There is an updated pull request by chrysos349 against master on the void-packages repository

https://github.com/chrysos349/void-packages Tuba
https://github.com/void-linux/void-packages/pull/44024

Tuba: update to 0.3.2
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-LIBC)

A patch file from https://github.com/void-linux/void-packages/pull/44024.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-Tuba-44024.patch --]
[-- Type: text/x-diff, Size: 1516 bytes --]

From 76398371f247ffba070524032c97e9ea1f6c8bdf Mon Sep 17 00:00:00 2001
From: chrysos349 <chrysostom349@gmail.com>
Date: Mon, 22 May 2023 05:32:53 +0300
Subject: [PATCH] Tuba: update to 0.3.2

---
 srcpkgs/Tuba/template | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/Tuba/template b/srcpkgs/Tuba/template
index fc2974bde2e0..3df3485ffa91 100644
--- a/srcpkgs/Tuba/template
+++ b/srcpkgs/Tuba/template
@@ -1,14 +1,21 @@
 # Template file for 'Tuba'
 pkgname=Tuba
-version=0.2.0
+version=0.3.2
 revision=1
 build_style=meson
 configure_args="-Ddistro=true"
-hostmakedepends="pkg-config gettext desktop-file-utils vala glib-devel"
-makedepends="libadwaita-devel libgee-devel libsecret-devel gtksourceview5-devel"
+hostmakedepends="desktop-file-utils gettext pkg-config"
+makedepends="gtksourceview5-devel libadwaita-devel libgee-devel libsecret-devel
+ libwebp-devel"
+depends="webp-pixbuf-loader"
+checkdepends="appstream-glib"
 short_desc="Browse the fediverse"
 maintainer="Michal Vasilek <michal@vasilek.cz>"
 license="GPL-3.0-only"
-homepage="https://tuba.geopjr.dev/"
-distfiles="https://github.com/GeopJr/Tuba/archive/refs/tags/v${version}.tar.gz"
-checksum=c698206bbbd06a1ce5a6e8cc9e6590411dc1cce1dde87fb0e34d8e35432ee2b1
+homepage="https://github.com/GeopJr/Tuba"
+distfiles="${homepage}/archive/v${version}.tar.gz"
+checksum=1458b343f069efca00b0b5da49b9eb4b529e49de3d701da06d9529828be19cf9
+
+post_install() {
+	ln -s dev.geopjr.Tuba ${DESTDIR}/usr/bin/tuba
+}

Re: [PR PATCH] [Updated] Tuba: update to 0.3.2

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

There is an updated pull request by chrysos349 against master on the void-packages repository

https://github.com/chrysos349/void-packages Tuba
https://github.com/void-linux/void-packages/pull/44024

Tuba: update to 0.3.2
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-LIBC)

A patch file from https://github.com/void-linux/void-packages/pull/44024.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-Tuba-44024.patch --]
[-- Type: text/x-diff, Size: 1417 bytes --]

From 46997dd801f4859f560123f2be56d230b10b902a Mon Sep 17 00:00:00 2001
From: chrysos349 <chrysostom349@gmail.com>
Date: Mon, 22 May 2023 05:32:53 +0300
Subject: [PATCH] Tuba: update to 0.3.2

---
 srcpkgs/Tuba/template | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/Tuba/template b/srcpkgs/Tuba/template
index fc2974bde2e0..10be9d84a394 100644
--- a/srcpkgs/Tuba/template
+++ b/srcpkgs/Tuba/template
@@ -1,14 +1,21 @@
 # Template file for 'Tuba'
 pkgname=Tuba
-version=0.2.0
+version=0.3.2
 revision=1
 build_style=meson
 configure_args="-Ddistro=true"
-hostmakedepends="pkg-config gettext desktop-file-utils vala glib-devel"
-makedepends="libadwaita-devel libgee-devel libsecret-devel gtksourceview5-devel"
+hostmakedepends="pkg-config gettext desktop-file-utils"
+makedepends="libadwaita-devel libgee-devel libsecret-devel gtksourceview5-devel
+ libwebp-devel"
+depends="webp-pixbuf-loader"
+checkdepends="appstream-glib"
 short_desc="Browse the fediverse"
 maintainer="Michal Vasilek <michal@vasilek.cz>"
 license="GPL-3.0-only"
 homepage="https://tuba.geopjr.dev/"
 distfiles="https://github.com/GeopJr/Tuba/archive/refs/tags/v${version}.tar.gz"
-checksum=c698206bbbd06a1ce5a6e8cc9e6590411dc1cce1dde87fb0e34d8e35432ee2b1
+checksum=1458b343f069efca00b0b5da49b9eb4b529e49de3d701da06d9529828be19cf9
+
+post_install() {
+	ln -s dev.geopjr.Tuba ${DESTDIR}/usr/bin/tuba
+}

Re: [PR REVIEW] Tuba: update to 0.3.2

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 493 bytes --]

New review comment by chrysos349 on void-packages repository

https://github.com/void-linux/void-packages/pull/44024#discussion_r1202126177

Comment:
Thanks for your feedback, @paper42 ! It turns out I messed with your template. Changes reverted.
`Vala` and `glib-devel` are deps of `libadwaita-devel`. So I removed them, correct?

BTW, the change is not random. The deps were sorted alphabetically. Am I not allowed to do this? Or is it easier to review changes when things stay the same?

Re: [PR REVIEW] Tuba: update to 0.3.2

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

New review comment by chrysos349 on void-packages repository

https://github.com/void-linux/void-packages/pull/44024#discussion_r1202128492

Comment:
Reverted. Could you explain why? Is the old version of a `homepage` variable more preferable? Is the old version of a `distfiles` variable more preferable?

Re: [PR REVIEW] Tuba: update to 0.3.2

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New review comment by chrysos349 on void-packages repository

https://github.com/void-linux/void-packages/pull/44024#discussion_r1202130037

Comment:
Easier to launch from the terminal. Saw it in the AUR template, liked it. Is this a bad practice?

Re: Tuba: update to 0.3.2

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 542 bytes --]

New comment by chrysos349 on void-packages repository

https://github.com/void-linux/void-packages/pull/44024#issuecomment-1559120150

Comment:
@paper42 Again, thanks for all your valuable feedback!

I read through [CONTRIBUTING.md](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md) and [Manual.md](https://github.com/void-linux/void-packages/blob/master/Manual.md) . I guess I need some more pointers in regards to other (unwritten) rules.

All I want is to help maintaining packages in my fav distro. That's all!

Re: [PR REVIEW] Tuba: update to 0.3.2

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 493 bytes --]

New review comment by chrysos349 on void-packages repository

https://github.com/void-linux/void-packages/pull/44024#discussion_r1202126177

Comment:
Thanks for your feedback, @paper42 ! It turns out I messed with your template. Changes reverted.
`vala` and `glib-devel` are deps of `libadwaita-devel`. So I removed them, correct?

BTW, the change is not random. The deps were sorted alphabetically. Am I not allowed to do this? Or is it easier to review changes when things stay the same?

Re: [PR PATCH] [Updated] Tuba: update to 0.3.2

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

There is an updated pull request by chrysos349 against master on the void-packages repository

https://github.com/chrysos349/void-packages Tuba
https://github.com/void-linux/void-packages/pull/44024

Tuba: update to 0.3.2
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-LIBC)

A patch file from https://github.com/void-linux/void-packages/pull/44024.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-Tuba-44024.patch --]
[-- Type: text/x-diff, Size: 1358 bytes --]

From dc57e6f5a4bdefedbc98a341cef28420c6407b76 Mon Sep 17 00:00:00 2001
From: chrysos349 <chrysostom349@gmail.com>
Date: Mon, 22 May 2023 05:32:53 +0300
Subject: [PATCH] Tuba: update to 0.3.2

---
 srcpkgs/Tuba/template | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/Tuba/template b/srcpkgs/Tuba/template
index fc2974bde2e0..0ec2767d4f70 100644
--- a/srcpkgs/Tuba/template
+++ b/srcpkgs/Tuba/template
@@ -1,14 +1,21 @@
 # Template file for 'Tuba'
 pkgname=Tuba
-version=0.2.0
+version=0.3.2
 revision=1
 build_style=meson
 configure_args="-Ddistro=true"
 hostmakedepends="pkg-config gettext desktop-file-utils vala glib-devel"
-makedepends="libadwaita-devel libgee-devel libsecret-devel gtksourceview5-devel"
+makedepends="libadwaita-devel libgee-devel libsecret-devel gtksourceview5-devel
+ libwebp-devel"
+depends="webp-pixbuf-loader"
+checkdepends="appstream-glib"
 short_desc="Browse the fediverse"
 maintainer="Michal Vasilek <michal@vasilek.cz>"
 license="GPL-3.0-only"
 homepage="https://tuba.geopjr.dev/"
 distfiles="https://github.com/GeopJr/Tuba/archive/refs/tags/v${version}.tar.gz"
-checksum=c698206bbbd06a1ce5a6e8cc9e6590411dc1cce1dde87fb0e34d8e35432ee2b1
+checksum=1458b343f069efca00b0b5da49b9eb4b529e49de3d701da06d9529828be19cf9
+
+post_install() {
+	ln -s dev.geopjr.Tuba ${DESTDIR}/usr/bin/tuba
+}

Re: [PR REVIEW] Tuba: update to 0.3.2

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New review comment by chrysos349 on void-packages repository

https://github.com/void-linux/void-packages/pull/44024#discussion_r1202632614

Comment:
I get it now. `vala` and `glibc-devel` are required for cross-compilation.

Re: [PR REVIEW] Tuba: update to 0.3.2

[paper42]

[-- Attachment #1: Type: text/plain, Size: 448 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/44024#discussion_r1202853867

Comment:
> BTW, the change is not random. The deps were sorted alphabetically. Am I not allowed to do this? Or is it easier to review changes when things stay the same?

Please don't do lint changes like this just for the sake of changing it. Do them only if you know this is a convention (and this is not).

Re: [PR REVIEW] Tuba: update to 0.3.2

[paper42]

[-- Attachment #1: Type: text/plain, Size: 620 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/44024#discussion_r1202853907

Comment:
homepage is supposed to be the homepage of the program, https://tuba.geopjr.dev/ is much much better for regular users than a github repository. Also, we are trying to avoid using $homepage in distfiles because it's an unnecessary variable for something that doesn't change and can mess with some scripts. As in the previous case, please don't apply these unnecessary fixes unless you know this style is preferred and keep the diff nice, small, clean and well review-able.

Re: [PR REVIEW] Tuba: update to 0.3.2

[paper42]

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/44024#discussion_r1202854010

Comment:
I am against this

Re: [PR PATCH] [Updated] Tuba: update to 0.3.2

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

There is an updated pull request by chrysos349 against master on the void-packages repository

https://github.com/chrysos349/void-packages Tuba
https://github.com/void-linux/void-packages/pull/44024

Tuba: update to 0.3.2
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-LIBC)

A patch file from https://github.com/void-linux/void-packages/pull/44024.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-Tuba-44024.patch --]
[-- Type: text/x-diff, Size: 1281 bytes --]

From abdfb80936559a14081e0d49e97af9efdc0901fd Mon Sep 17 00:00:00 2001
From: chrysos349 <chrysostom349@gmail.com>
Date: Mon, 22 May 2023 05:32:53 +0300
Subject: [PATCH] Tuba: update to 0.3.2

---
 srcpkgs/Tuba/template | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/Tuba/template b/srcpkgs/Tuba/template
index fc2974bde2e0..18cf6d24e3b2 100644
--- a/srcpkgs/Tuba/template
+++ b/srcpkgs/Tuba/template
@@ -1,14 +1,17 @@
 # Template file for 'Tuba'
 pkgname=Tuba
-version=0.2.0
+version=0.3.2
 revision=1
 build_style=meson
 configure_args="-Ddistro=true"
 hostmakedepends="pkg-config gettext desktop-file-utils vala glib-devel"
-makedepends="libadwaita-devel libgee-devel libsecret-devel gtksourceview5-devel"
+makedepends="libadwaita-devel libgee-devel libsecret-devel gtksourceview5-devel
+ libwebp-devel"
+depends="webp-pixbuf-loader"
+checkdepends="appstream-glib"
 short_desc="Browse the fediverse"
 maintainer="Michal Vasilek <michal@vasilek.cz>"
 license="GPL-3.0-only"
 homepage="https://tuba.geopjr.dev/"
 distfiles="https://github.com/GeopJr/Tuba/archive/refs/tags/v${version}.tar.gz"
-checksum=c698206bbbd06a1ce5a6e8cc9e6590411dc1cce1dde87fb0e34d8e35432ee2b1
+checksum=1458b343f069efca00b0b5da49b9eb4b529e49de3d701da06d9529828be19cf9

Re: [PR REVIEW] Tuba: update to 0.3.2

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

New review comment by chrysos349 on void-packages repository

https://github.com/void-linux/void-packages/pull/44024#discussion_r1203016574

Comment:
This is useful! I will keep the diff small and clean in the future!

P.S. Doesn't this piece of information need to be in [CONTRIBUTING.md](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md)?

Re: [PR REVIEW] Tuba: update to 0.3.2

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

New review comment by chrysos349 on void-packages repository

https://github.com/void-linux/void-packages/pull/44024#discussion_r1203018776

Comment:
Removed.

Please clarify. Are you against this in your templates? Or are you (as a member of VoidLinux) against such practice in any templates?

Re: [PR REVIEW] Tuba: update to 0.3.2

[paper42]

[-- Attachment #1: Type: text/plain, Size: 644 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/44024#discussion_r1203157217

Comment:
I am personally against us (a distribution) creating a symlink for a graphical program just so it is easier to launch from CLI. We have to choose the same symlink name as all other distributions, make sure it doesn't conflict with any other package and somehow solve conflicts in that case. If people want to have an alias, they can set it, but launching a graphical application should be usually done with a graphical launcher which parses uses standard .desktop files instead of plain commands.

Re: [PR REVIEW] Tuba: update to 0.3.2

[paper42]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/44024#discussion_r1203159013

Comment:
I am not sure what exactly should be added there, keeping commits clean and not doing unrelated or unnecessary changes is just a basic git best practice.

Re: [PR REVIEW] Tuba: update to 0.3.2

[paper42]

[-- Attachment #1: Type: text/plain, Size: 714 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/44024#discussion_r1203157217

Comment:
I am personally against us (a distribution) creating a symlink for a graphical program just so it is easier to launch from CLI. We would have to choose the same symlink name as all other distributions (otherwise it would be very painful and confusing), make sure it doesn't conflict with any other package and somehow solve conflicts in that case. If people want to have an alias, they can set it on their own, but launching a graphical application should be usually done with a graphical launcher which parses uses standard .desktop files instead of plain commands.

Re: Tuba: update to 0.3.2

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/44024#issuecomment-1575517319

Comment:
Tested and everything seems to run fine on my machine!
Since `webp-pixbuf-loader` is only an optional dependency for webp support, I'm not sure if it should be added as a dependency :thinking:

Re: Tuba: update to 0.3.2

[paper42]

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/44024#issuecomment-1575524975

Comment:
> Since `webp-pixbuf-loader` is only an optional dependency for webp support, I'm not sure if it should be added as a dependency thinking

I think it's ok to add it in this case because some servers only apparently use webp and without this dependency, they wouldn't work.

Re: [PR PATCH] [Merged]: Tuba: update to 0.3.2

[paper42]

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

There's a merged pull request on the void-packages repository

Tuba: update to 0.3.2
https://github.com/void-linux/void-packages/pull/44024

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-LIBC)

Re: Tuba: update to 0.3.2

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/44253#issuecomment-1575507988

Comment:
My bad!
I'll do that, sure!

Re: Tuba: update to 0.3.2

[paper42]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/44253#issuecomment-1575507131

Comment:
duplicate of #44024, could you test that PR and comment your findings there?