From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] Tuba: update to 0.3.2
Date: Tue, 23 May 2023 20:50:37 +0200 [thread overview]
Message-ID: <20230523185037.7ly4AEgrgLU2fI--BplicQ-O-uW-X2W3s8qq70wGiP8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-44024@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 620 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/44024#discussion_r1202853907
Comment:
homepage is supposed to be the homepage of the program, https://tuba.geopjr.dev/ is much much better for regular users than a github repository. Also, we are trying to avoid using $homepage in distfiles because it's an unnecessary variable for something that doesn't change and can mess with some scripts. As in the previous case, please don't apply these unnecessary fixes unless you know this style is preferred and keep the diff nice, small, clean and well review-able.
next prev parent reply other threads:[~2023-05-23 18:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 2:34 [PR PATCH] " chrysos349
2023-05-23 7:48 ` [PR REVIEW] " paper42
2023-05-23 7:48 ` paper42
2023-05-23 7:48 ` paper42
2023-05-23 11:08 ` [PR PATCH] [Updated] " chrysos349
2023-05-23 11:21 ` chrysos349
2023-05-23 11:27 ` [PR REVIEW] " chrysos349
2023-05-23 11:28 ` chrysos349
2023-05-23 11:30 ` chrysos349
2023-05-23 11:38 ` chrysos349
2023-05-23 11:46 ` [PR REVIEW] " chrysos349
2023-05-23 16:06 ` [PR PATCH] [Updated] " chrysos349
2023-05-23 16:07 ` [PR REVIEW] " chrysos349
2023-05-23 18:50 ` paper42
2023-05-23 18:50 ` paper42 [this message]
2023-05-23 18:50 ` paper42
2023-05-23 21:05 ` [PR PATCH] [Updated] " chrysos349
2023-05-23 21:10 ` [PR REVIEW] " chrysos349
2023-05-23 21:12 ` chrysos349
2023-05-23 23:38 ` paper42
2023-05-23 23:40 ` paper42
2023-05-23 23:58 ` paper42
2023-06-04 10:52 ` Bnyro
2023-06-04 11:11 ` paper42
2023-06-04 11:12 ` [PR PATCH] [Merged]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230523185037.7ly4AEgrgLU2fI--BplicQ-O-uW-X2W3s8qq70wGiP8@z \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).