From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: xbps-triggers: exit kernel hook on error
Date: Thu, 25 May 2023 20:40:14 +0200 [thread overview]
Message-ID: <20230525184014.SaPsv9j08dhRj9es32n5It1GhtzqarZFCieaFH9xayw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43852@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 619 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/43852#issuecomment-1563343499
Comment:
I don't believe this is desirable. There may be any number of kernel hooks that might be effectively independent, and preventing some from running just because one failed could have unintended consequences. This is especially true because this represents a change in behavior. If one hook depends on the success of another, *e.g.* by acting on its outputs, the right thing to do is confirm in the dependant hook that all expected inputs are present and fail gracefully if not.
next prev parent reply other threads:[~2023-05-25 18:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 9:06 [PR PATCH] " g4s8
2023-05-19 8:36 ` g4s8
2023-05-25 18:40 ` ahesford [this message]
2023-06-27 22:27 ` classabbyamp
2023-06-27 23:26 ` [PR PATCH] [Closed]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230525184014.SaPsv9j08dhRj9es32n5It1GhtzqarZFCieaFH9xayw@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).