From: hazen2215 <hazen2215@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] gforth: fix build on musl
Date: Sun, 28 May 2023 13:09:14 +0200 [thread overview]
Message-ID: <20230528110914.lrBt8OMq4LT6W-d1e9m0qs2VzO-ItTLZKtzNnYUXVYw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42876@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]
There is an updated pull request by hazen2215 against master on the void-packages repository
https://github.com/hazen2215/void-packages gforth
https://github.com/void-linux/void-packages/pull/42876
gforth: fix build on musl
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
A patch file from https://github.com/void-linux/void-packages/pull/42876.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gforth-42876.patch --]
[-- Type: text/x-diff, Size: 914 bytes --]
From 8ff90b1a548fb3b1f7278b62796ae7e7273a24d6 Mon Sep 17 00:00:00 2001
From: hazen2215 <haz@disroot.org>
Date: Mon, 20 Mar 2023 17:27:20 +0900
Subject: [PATCH] gforth: fix build on musl
---
srcpkgs/gforth/template | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/gforth/template b/srcpkgs/gforth/template
index f0df03991086..053a4814dd8e 100644
--- a/srcpkgs/gforth/template
+++ b/srcpkgs/gforth/template
@@ -14,6 +14,8 @@ checksum=2f62f2233bf022c23d01c920b1556aa13eab168e3236b13352ac5e9f18542bb0
disable_parallel_build=yes
nocross="Configure script is picky: https://api.travis-ci.org/jobs/158049419/log.txt?deansi=true"
-case "${XBPS_TARGET_MACHINE}" in
- *-musl) broken="Tests fail, might just be a flushing problem";;
-esac
+if [ "$XBPS_TARGET_LIBC" = musl ]; then
+ # Tests fail, might just be a flushing problem
+ make_check=no
+ configure_args="--without-check"
+fi
next prev parent reply other threads:[~2023-05-28 11:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 8:33 [PR PATCH] " hazen2215
2023-03-20 14:50 ` [PR REVIEW] " sgn
2023-03-20 15:40 ` [PR PATCH] [Updated] " hazen2215
2023-05-28 11:09 ` hazen2215 [this message]
2023-06-05 17:19 ` hazen2215
2023-06-23 20:04 ` [PR PATCH] [Merged]: " Duncaen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230528110914.lrBt8OMq4LT6W-d1e9m0qs2VzO-ItTLZKtzNnYUXVYw@z \
--to=hazen2215@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).