From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: n-9.1.0
Date: Tue, 30 May 2023 20:40:06 +0200 [thread overview]
Message-ID: <20230530184006.V72ByeEz4YqeRzxqLjW1dlTgpEoBstxJ39lcf4Hq9dM@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43666@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 338 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/43666#discussion_r1210680464
Comment:
The makefile doesn't seem to respect $DESTDIR which means do_install would put it to the masterdir and not destdir, but the part about not having to use the second argument should be changed
next prev parent reply other threads:[~2023-05-30 18:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-29 6:31 [PR PATCH] " akierig
2023-04-29 6:34 ` akierig
2023-04-29 6:34 ` akierig
2023-04-29 6:37 ` akierig
2023-04-29 6:49 ` [PR PATCH] [Updated] " akierig
2023-04-29 6:50 ` akierig
2023-04-29 6:52 ` akierig
2023-04-29 7:09 ` akierig
2023-04-29 7:17 ` akierig
2023-05-22 18:46 ` akierig
2023-05-30 18:11 ` [PR REVIEW] " mhmdanas
2023-05-30 18:12 ` mhmdanas
2023-05-30 18:39 ` paper42
2023-05-30 18:39 ` paper42
2023-05-30 18:40 ` paper42 [this message]
2023-05-30 18:40 ` paper42
2023-05-30 18:56 ` [PR PATCH] [Updated] " akierig
2023-05-30 19:25 ` akierig
2023-06-24 12:06 ` [PR PATCH] [Merged]: " Duncaen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230530184006.V72ByeEz4YqeRzxqLjW1dlTgpEoBstxJ39lcf4Hq9dM@z \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).