From: chloris-pale-green <chloris-pale-green@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: Package Request: Jami
Date: Thu, 01 Jun 2023 12:02:31 +0200 [thread overview]
Message-ID: <20230601100231.QtLWNe5ih1o1V7ziKIHd4kc2dvHBIFUn9s9Pn31mMyE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-4420@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 5310 bytes --]
New comment by chloris-pale-green on void-packages repository
https://github.com/void-linux/void-packages/issues/4420#issuecomment-1571738791
Comment:
I've almost successfully packaged `jami-daemon` (see [this commit](https://github.com/chloris-pale-green/void-packages/commit/e2e1ef07781df3376d0ac3ad15485c36f569caa2)). The build documentation is quite abysmal. I've ripped off most of the build process from Arch. Dependencies compile successfully, the configure step is successful (except some complaining about `dbus`, which can be disabled, if needed), but the `jami-daemon` itself fails to compile. We don't have `libnatpmp` in the repos, if that's desired.
The compile error seems to be about class member naming:
```
=> jami-daemon-20230601_1: running do_build ...
make all-recursive
make[1]: Entering directory '/builddir/jami-daemon-20230601'
Making all in src
make[2]: Entering directory '/builddir/jami-daemon-20230601/src'
CXX buildinfo.lo
CXX conference.lo
CXX conference_protocol.lo
CXX account_factory.lo
CXX call_factory.lo
CXX preferences.lo
CXX manager.lo
CXX call.lo
CXX gittransport.lo
In file included from /builddir/jami-daemon-20230601/src/media/video/video_input.h:27,
from client/videomanager.h:35,
from preferences.cpp:58:
/builddir/jami-daemon-20230601/src/media/media_stream.h: In constructor 'jami::MediaStream::MediaStream(const std::string&, AVCodecContext*, int64_t)':
/builddir/jami-daemon-20230601/src/media/media_stream.h:115:33: error: 'AVCodecContext' {aka 'struct AVCodecContext'} has no member named 'ch_layout'; did you mean 'channel_layout'?
115 | nbChannels = c->ch_layout.nb_channels;
| ^~~~~~~~~
| channel_layout
/builddir/jami-daemon-20230601/src/media/media_stream.h: In member function 'void jami::MediaStream::update(AVFrame*)':
/builddir/jami-daemon-20230601/src/media/media_stream.h:147:29: error: 'AVFrame' {aka 'struct AVFrame'} has no member named 'ch_layout'; did you mean 'channel_layout'?
147 | nbChannels = f->ch_layout.nb_channels;
| ^~~~~~~~~
| channel_layout
In file included from /builddir/jami-daemon-20230601/src/media/media_encoder.h:36,
from /builddir/jami-daemon-20230601/src/media/media_recorder.h:27,
from /builddir/jami-daemon-20230601/src/media/recordable.h:25,
from call.h:32,
from call_factory.h:30,
from call_factory.cpp:23:
/builddir/jami-daemon-20230601/src/media/media_stream.h: In constructor 'jami::MediaStream::MediaStream(const std::string&, AVCodecContext*, int64_t)':
/builddir/jami-daemon-20230601/src/media/media_stream.h:115:33: error: 'AVCodecContext' {aka 'struct AVCodecContext'} has no member named 'ch_layout'; did you mean 'channel_layout'?
115 | nbChannels = c->ch_layout.nb_channels;
| ^~~~~~~~~
| channel_layout
/builddir/jami-daemon-20230601/src/media/media_stream.h: In member function 'void jami::MediaStream::update(AVFrame*)':
/builddir/jami-daemon-20230601/src/media/media_stream.h:147:29: error: 'AVFrame' {aka 'struct AVFrame'} has no member named 'ch_layout'; did you mean 'channel_layout'?
147 | nbChannels = f->ch_layout.nb_channels;
| ^~~~~~~~~
| channel_layout
In file included from /builddir/jami-daemon-20230601/src/media/media_encoder.h:36,
from /builddir/jami-daemon-20230601/src/media/media_recorder.h:27,
from /builddir/jami-daemon-20230601/src/media/recordable.h:25,
from call.h:32,
from call_factory.h:30,
from manager.h:35,
from manager.cpp:35:
/builddir/jami-daemon-20230601/src/media/media_stream.h: In constructor 'jami::MediaStream::MediaStream(const std::string&, AVCodecContext*, int64_t)':
/builddir/jami-daemon-20230601/src/media/media_stream.h:115:33: error: 'AVCodecContext' {aka 'struct AVCodecContext'} has no member named 'ch_layout'; did you mean 'channel_layout'?
115 | nbChannels = c->ch_layout.nb_channels;
| ^~~~~~~~~
| channel_layout
/builddir/jami-daemon-20230601/src/media/media_stream.h: In member function 'void jami::MediaStream::update(AVFrame*)':
/builddir/jami-daemon-20230601/src/media/media_stream.h:147:29: error: 'AVFrame' {aka 'struct AVFrame'} has no member named 'ch_layout'; did you mean 'channel_layout'?
147 | nbChannels = f->ch_layout.nb_channels;
| ^~~~~~~~~
| channel_layout
```
And so on... Any suggestions? Is is sloppy code or does one of our libraries have different variable names in it than on another distro (`ch_layout` vs `channel_layout`)? We don't need to patch the source files to rename them, right? If that's the case, `sed` would probably do the job.
next prev parent reply other threads:[~2023-06-01 10:02 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-4420@inbox.vuxu.org>
2019-10-29 0:35 ` Package Request: Ring voidlinux-github
2020-03-05 18:40 ` avoidr
2020-09-14 9:29 ` Mirodin
2021-04-25 9:48 ` autoteelar
2021-10-10 20:35 ` Package Request: Ring / Jami mika-nl
2021-10-10 20:39 ` mika-nl
2021-10-11 18:59 ` Chocimier
2021-10-13 18:22 ` mika-nl
2021-10-19 1:18 ` jgarte
2022-04-15 0:50 ` github-actions
2022-06-25 1:39 ` Package Request: Jami classabbyamp
2022-06-30 19:22 ` Idesmi
2022-06-30 21:49 ` ericonr
2023-06-01 6:41 ` chloris-pale-green
2023-06-01 10:01 ` chloris-pale-green
2023-06-01 10:02 ` chloris-pale-green [this message]
2023-06-01 14:00 ` chloris-pale-green
2023-06-01 14:05 ` chloris-pale-green
2023-06-01 14:22 ` chloris-pale-green
2023-06-01 14:22 ` chloris-pale-green
2023-06-01 14:22 ` chloris-pale-green
2023-06-01 15:00 ` chloris-pale-green
2023-08-26 14:14 ` HanoJing
2023-08-30 18:14 ` Chocimier
2021-10-16 2:51 [ISSUE] Package Request: jami jgarte
2021-10-16 7:53 ` notthewave
-- strict thread matches above, loose matches on Subject: below --
2021-04-25 9:48 [ISSUE] Package Request: Jami autoteelar
2021-04-25 13:19 ` notthewave
2021-04-25 13:20 ` notthewave
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230601100231.QtLWNe5ih1o1V7ziKIHd4kc2dvHBIFUn9s9Pn31mMyE@z \
--to=chloris-pale-green@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).