Github messages for voidlinux
 help / color / mirror / Atom feed
From: Duncaen <Duncaen@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: linux-wifi-hotspot-4.5.0
Date: Thu, 01 Jun 2023 16:34:37 +0200	[thread overview]
Message-ID: <20230601143437.ihQ7Luc_oZN6eKVZDLVK9KrPww62QWiXHlkVGueolOk@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-44210@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 2239 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/44210#issuecomment-1572173879

Comment:
With this patch everything including cross builds work, the `gtk+3` dependency is added automatically since it links libgtk. 
```
diff --git a/srcpkgs/linux-wifi-hotspot/patches/makefile.patch b/srcpkgs/linux-wifi-hotspot/patches/makefile.patch
new file mode 100644
index 0000000000..aab21f83ce
--- /dev/null
+++ b/srcpkgs/linux-wifi-hotspot/patches/makefile.patch
@@ -0,0 +1,24 @@
+--- a/src/Makefile
++++ b/src/Makefile
+@@ -1,7 +1,7 @@
+ CC=gcc
+ PKGCONFIG = $(shell which pkg-config)
+
+-CFLAGS=`pkg-config --cflags gtk+-3.0`
++CFLAGS_PKGCONF=`pkg-config --cflags gtk+-3.0`
+ LIBS=`pkg-config --libs gtk+-3.0 --libs x11` -lstdc++ -lpng -lqrencode
+
+ APP_NAME="wihotspot"
+@@ -32,10 +32,10 @@
+       @$(MAKE) -f $(THIS_FILE) wihotspot-gui
+
+ $(ODIR)/%.o: ui/%.c
+-      $(CC) -c -o $@ $< $(CFLAGS)
++      $(CC) -c -o $@ $< $(CFLAGS) $(CFLAGS_PKGCONF)
+
+ $(ODIR)/%.o: ui/%.cpp
+-      g++ -c -o $@ $<
++      $(CXX) -c -o $@ $< $(CFLAGS)
+
+ wihotspot-gui: $(OBJ)
+       $(CC) -o $(ODIR)/$@ $^ $(CFLAGS) $(LIBS)
diff --git a/srcpkgs/linux-wifi-hotspot/template b/srcpkgs/linux-wifi-hotspot/template
index 990ff83a7b..a2c03b2682 100644
--- a/srcpkgs/linux-wifi-hotspot/template
+++ b/srcpkgs/linux-wifi-hotspot/template
@@ -2,11 +2,10 @@
 pkgname=linux-wifi-hotspot
 version=4.5.0
 revision=1
-archs="i686 x86_64 x86_64-musl"
-build_style=gnu-configure
+build_style=gnu-makefile
 hostmakedepends="pkg-config which glib-devel"
 makedepends="gtk+3-devel libpng-devel qrencode-devel"
-depends="gtk+3 bash dnsmasq hostapd iproute2 iptables iw procps-ng util-linux"
+depends="bash dnsmasq hostapd iproute2 iptables iw procps-ng util-linux"
 short_desc="Feature-rich wifi hotspot creator"
 maintainer="Bnyro <bnyro@tutanota.com>"
 license="BSD-2-Clause"
@@ -15,10 +14,6 @@ distfiles="https://github.com/lakinduakash/linux-wifi-hotspot/archive/refs/tags/
 checksum=9e4222b7d3129347b01eef711911ec87c9a04e20efd12d88565f682a14eb91da
 conflicts="create_ap"

-do_configure() {
-       :
-}
-
 post_install() {
        vlicense LICENSE
 }
```

  parent reply	other threads:[~2023-06-01 14:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-01 13:00 [PR PATCH] " Bnyro
2023-06-01 13:05 ` [PR PATCH] [Updated] " Bnyro
2023-06-01 13:07 ` Bnyro
2023-06-01 13:36 ` [PR REVIEW] " Duncaen
2023-06-01 13:38 ` Duncaen
2023-06-01 13:53 ` Bnyro
2023-06-01 13:54 ` Bnyro
2023-06-01 14:21 ` Duncaen
2023-06-01 14:34 ` Duncaen [this message]
2023-06-01 14:34 ` Duncaen
2023-06-01 15:42 ` [PR PATCH] [Updated] " Bnyro
2023-06-01 15:43 ` Bnyro
2023-06-08 14:43 ` unrealjo
2023-06-08 15:35 ` [PR REVIEW] " Duncaen
2023-06-08 15:40 ` [PR PATCH] [Updated] " Bnyro
2023-06-08 20:16 ` [PR REVIEW] " unrealjo
2023-06-08 20:26 ` unrealjo
2023-06-15 18:35 ` [PR PATCH] [Merged]: " Duncaen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230601143437.ihQ7Luc_oZN6eKVZDLVK9KrPww62QWiXHlkVGueolOk@z \
    --to=duncaen@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).