Github messages for voidlinux
 help / color / mirror / Atom feed
From: Duncaen <Duncaen@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: nginx-mod-rtmp
Date: Thu, 01 Jun 2023 21:19:31 +0200	[thread overview]
Message-ID: <20230601191931.8DydhvVCSllH6iHn895qthHRdKybUePZ-DkG4zfLOBA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-44206@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/44206#issuecomment-1572644590

Comment:
Some time ago I tested a setup like arch has in its main repo that creates an `nginx-src` sub-package that the modules would `hostmakedepends` on and copy the source and configure scripts form `/usr/src/nginx` into their build dir.

At that time I tried to patch the configure scripts to not require the fake configure run on host and static files for the cross targets, but never really finished it. [openembedded is using a similar patch](https://github.com/openembedded/meta-openembedded/blob/master/meta-webserver/recipes-httpd/nginx/files/nginx-cross.patch) but requiring to specify the values as configure arguments which is a bit annoying because you'll have to copy all of this to each module.
Maybe we could use the openembedded patch but extend it a bit by setting the defaults based on i.e. --target for all the added flags for the architectures we support.

With the patched configure script with defaults for all our targets the module templates would become a bit simpler, but probably still require some extra patching because they follow nginx and are not really cross build compatible.


  parent reply	other threads:[~2023-06-01 19:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-01  2:00 [PR PATCH] " agausmann
2023-06-01  9:19 ` Duncaen
2023-06-01 18:53 ` agausmann
2023-06-01 19:19 ` Duncaen
2023-06-01 19:19 ` Duncaen [this message]
2023-09-13  1:45 ` github-actions
2023-09-27  1:45 ` [PR PATCH] [Closed]: " github-actions

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230601191931.8DydhvVCSllH6iHn895qthHRdKybUePZ-DkG4zfLOBA@z \
    --to=duncaen@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).