Re: [PR PATCH] [Updated] Signal-Desktop: update to 6.20.0.

[akierig <akierig@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

There is an updated pull request by akierig against master on the void-packages repository

https://github.com/akierig/void-packages signal-6.20
https://github.com/void-linux/void-packages/pull/44205

Signal-Desktop: update to 6.20.0.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64


A patch file from https://github.com/void-linux/void-packages/pull/44205.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-signal-6.20-44205.patch --]
[-- Type: text/x-diff, Size: 2025 bytes --]

From 2c8a73c3fd79bfe65ca2b601cf4c98254d152e80 Mon Sep 17 00:00:00 2001
From: anelki <akierig@fastmail.de>
Date: Wed, 31 May 2023 18:20:33 -0500
Subject: [PATCH] Signal-Desktop: update to 6.20.0.

---
 srcpkgs/Signal-Desktop/template | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/Signal-Desktop/template b/srcpkgs/Signal-Desktop/template
index 4c6722055987..fec02583a29a 100644
--- a/srcpkgs/Signal-Desktop/template
+++ b/srcpkgs/Signal-Desktop/template
@@ -1,34 +1,38 @@
 # Template file for 'Signal-Desktop'
 pkgname=Signal-Desktop
-version=6.19.0
+version=6.20.0
 revision=1
 # Signal officially only supports x86_64 
 # x86_64-musl could potentially work based on the Alpine port:
 # https://git.alpinelinux.org/aports/tree/testing/signal-desktop
 # ARM: https://github.com/signalapp/Signal-Desktop/issues/3410
 archs="x86_64"
-hostmakedepends="git git-lfs nodejs python3 tar yarn"
+hostmakedepends="git git-lfs nodeenv python3 tar"
 depends="cairo gtk+3 libvips pango"
 short_desc="Signal Private Messenger for Linux"
 maintainer="anelki <akierig@fastmail.de>"
 license="AGPL-3.0-only"
 homepage="https://github.com/signalapp/Signal-Desktop"
 distfiles="https://github.com/signalapp/Signal-Desktop/archive/v${version}.tar.gz"
-checksum=965702b217b39131c61e62c63fb25b073750a8f6febdffa9db236626124c6e50
+checksum=fc92011c51da6792215eb92d48afc17f1967caeade1307daaa13884244d7a3b0
 nostrip_files="signal-desktop"
 
 post_extract() {
 	# git-lfs hook needs to be installed for one of the dependencies
 	git lfs install
 
-	#vsed 's/"node": "/&>=/' -i package.json
-	vsed 's/"node": "18.14.0"/"node": ">=16.19.0"/' -i package.json
+	# use nodeenv since we have that in the repos already
+	nodeenv --node='18.14.0' signal-node
+	. ./signal-node/bin/activate
+
+	npm install -g yarn
 
 	# Dependencies have to be installed before applying patch
 	yarn install --ignore-engines --frozen-lockfile
 }
 
 do_build() {
+	. ./signal-node/bin/activate
 	yarn generate
 	yarn build-release
 }