Github messages for voidlinux
 help / color / mirror / Atom feed
From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: nodejs: update to 18.16.0.
Date: Sat, 03 Jun 2023 21:35:38 +0200	[thread overview]
Message-ID: <20230603193538.4VCm8hE1llH7TQNdKmyRSgia-uAWEtAZKfUVxKLJn0Q@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-41239@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 588 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/41239#issuecomment-1575150287

Comment:
> I was able to build Node 18.15.0 successfully with `--enable-lto` passed to `./configure`, so you may want to add that to the template @paper42. Additionally, the package uses some vendored dependencies that are available in the repos (e.g. brotli), so you might want to make the package use those dependencies from the repos instead.

hi, I think that moving this PR forward is more important than this for now, could you open a separate PR?

  parent reply	other threads:[~2023-06-03 19:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-22 16:29 [PR PATCH] [NOMERGE] nodejs: update to 18.12.1 paper42
2022-12-22 16:44 ` [PR PATCH] [Updated] " paper42
2022-12-24 23:44 ` paper42
2023-03-02 20:45 ` paper42
2023-03-06 22:46 ` dkwo
2023-03-23 10:13 ` mhmdanas
2023-06-02 20:06 ` [PR PATCH] [Updated] " paper42
2023-06-03 19:35 ` paper42 [this message]
2023-06-03 19:47 ` [PR PATCH] [Closed]: nodejs: update to 18.16.0 paper42
2023-06-03 19:47 ` paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230603193538.4VCm8hE1llH7TQNdKmyRSgia-uAWEtAZKfUVxKLJn0Q@z \
    --to=paper42@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).