From: tornaria <tornaria@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] Updates to python test packages
Date: Tue, 06 Jun 2023 02:17:54 +0200 [thread overview]
Message-ID: <20230606001754.crWjDkd9J8wGWBnBjf4TOcPRpWrdAW-DKDxC_Qpapa0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-44272@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 916 bytes --]
New review comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/44272#discussion_r1218734802
Comment:
Fair enough, thanks for the comments.
I just right-clicked and used "copy link" to get the link, and my xchangelog uses `curl -sL` to download so it works and I didn't realize this was a redirect. The server changes so it's not even a "free" redirect.
OTOH I'd worry about which URL is the most stable one of the two (for some reason gh itself links via the first one and then redirects) but I guess it's unlikely that either one changes.
I'll review everything and update all the changelog links (on the bright side, I think I got text changelogs for everything).
Moreover, I want to work out a little bit more on the templates that use a venv to check, to see if a similar workaround as in #44268 might work instead of a custom `do_check()`. Keep tuned.
next prev parent reply other threads:[~2023-06-06 0:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 6:41 [PR PATCH] " tornaria
2023-06-05 14:41 ` [PR PATCH] [Updated] " tornaria
2023-06-05 14:44 ` tornaria
2023-06-05 17:26 ` [PR REVIEW] " mhmdanas
2023-06-05 21:26 ` classabbyamp
2023-06-05 21:29 ` mhmdanas
2023-06-06 0:17 ` tornaria [this message]
2023-06-06 2:59 ` [PR PATCH] [Updated] " tornaria
2023-06-06 2:59 ` [PR REVIEW] " tornaria
2023-06-06 3:27 ` tornaria
2023-06-09 1:46 ` [PR PATCH] [Closed]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230606001754.crWjDkd9J8wGWBnBjf4TOcPRpWrdAW-DKDxC_Qpapa0@z \
--to=tornaria@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).