From: hervyqa <hervyqa@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: swayfx-0.3.1
Date: Sat, 10 Jun 2023 13:13:24 +0200 [thread overview]
Message-ID: <20230610111324.gqbw__CDRJkHtvK8_R-mPSGJeC1b9671sAVGTMf021Y@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-44256@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]
New comment by hervyqa on void-packages repository
https://github.com/void-linux/void-packages/pull/44256#issuecomment-1585620614
Comment:
@justinesmithies thanks, good work! 😊
but there are some problems here.
- use a branch other than `master`. [^1]
- use only one commit (or merge existing commits with `git rebase -i`). [^2]
*Using the `master` branch of your fork for contributing is also strongly discouraged. It can cause many issues with updating your pull request (also called a PR), and having multiple PRs open at once. To create a new branch:*
```
$ git checkout master -b <a-descriptive-name>
```
for example with `swayfx` branch.
```
$ git checkout master -b swayfx
```
Reference:
[^1]: Voidlinux contribution: https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#creating-updating-and-modifying-packages-in-void-by-yourself
[^2]: How combine two commits into one commit: https://stackoverflow.com/questions/12522565/how-can-i-combine-two-commits-into-one-commit
next prev parent reply other threads:[~2023-06-10 11:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-04 12:45 [PR PATCH] " justinesmithies
2023-06-04 12:50 ` paper42
2023-06-07 18:16 ` [PR PATCH] [Updated] " justinesmithies
2023-06-08 18:59 ` justinesmithies
2023-06-08 18:59 ` justinesmithies
2023-06-09 6:51 ` justinesmithies
2023-06-09 17:28 ` justinesmithies
2023-06-09 19:19 ` justinesmithies
2023-06-09 19:19 ` justinesmithies
2023-06-09 20:09 ` justinesmithies
2023-06-10 11:03 ` justinesmithies
2023-06-10 11:13 ` hervyqa [this message]
2023-07-02 22:46 ` hervyqa
2023-07-16 17:45 ` [PR PATCH] [Closed]: " justinesmithies
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230610111324.gqbw__CDRJkHtvK8_R-mPSGJeC1b9671sAVGTMf021Y@z \
--to=hervyqa@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).