From: SpidFightFR <SpidFightFR@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: PrismLauncher: update to 7.1.
Date: Sat, 17 Jun 2023 16:42:03 +0200 [thread overview]
Message-ID: <20230617144203.DqjJeHwqWkUFVdWVpJGgAcR-0_e7OpOrscRoGRJiCzQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-44326@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1363 bytes --]
New comment by SpidFightFR on void-packages repository
https://github.com/void-linux/void-packages/pull/44326#issuecomment-1595718328
Comment:
back again on this PR, i changed the commit and the title of the PR as i used the template i made this morning for my prismlauncher installation.
Just in case, the first message stays true:
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x64-GlibC)
#### Additional notes for the PR
- Kept the changes with openjdk, i can confirm it works.
- We should stay on QT5 (`-DLauncher_QT_VERSION_MAJOR='5'` argument), as PrismLauncher both supports QT5 and QT6. Switching to QT6 brings nothing really useful, but it does bring **issues with the plasma5 D.E**, especially in terms of theming. So like i said earlier, we should remain this argument for as long as Plasma staying on QT5. Once plama QT6 is out, we could add the changes provided by @classabbyamp (https://github.com/void-linux/void-packages/pull/44326#issuecomment-1584977013).
- ~~When building PrismLauncher, it also builds PolyMC~~, that should not be happening and we should fix this. Those two launchers are **separated** launchers, and PolyMC can even bring security issues related to specific changes brought by it's main maintainer.
next prev parent reply other threads:[~2023-06-17 14:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 9:22 [PR PATCH] PrismLauncher: update to 7.0 SpidFightFR
2023-06-09 18:22 ` classabbyamp
2023-06-10 6:20 ` SpidFightFR
2023-06-10 7:10 ` SpidFightFR
2023-06-10 8:40 ` classabbyamp
2023-06-10 13:15 ` SpidFightFR
2023-06-10 13:15 ` SpidFightFR
2023-06-11 9:25 ` oynqr
2023-06-11 10:02 ` SpidFightFR
2023-06-11 11:17 ` classabbyamp
2023-06-17 11:24 ` [PR PATCH] [Updated] " SpidFightFR
2023-06-17 11:31 ` PrismLauncher: update to 7.1 SpidFightFR
2023-06-17 14:41 ` [PR PATCH] [Updated] " SpidFightFR
2023-06-17 14:42 ` SpidFightFR [this message]
2023-06-17 14:42 ` SpidFightFR
2023-06-17 15:18 ` [PR REVIEW] " classabbyamp
2023-06-17 16:29 ` SpidFightFR
2023-06-17 16:30 ` SpidFightFR
2023-06-17 16:35 ` classabbyamp
2023-06-17 17:04 ` SpidFightFR
2023-06-17 17:20 ` classabbyamp
2023-06-18 6:24 ` [PR PATCH] [Updated] " SpidFightFR
2023-06-18 7:09 ` [PR PATCH] [Merged]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230617144203.DqjJeHwqWkUFVdWVpJGgAcR-0_e7OpOrscRoGRJiCzQ@z \
--to=spidfightfr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).