Github messages for voidlinux
 help / color / mirror / Atom feed
From: Duncaen <Duncaen@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: seer-1.17
Date: Sat, 24 Jun 2023 14:05:19 +0200	[thread overview]
Message-ID: <20230624120519.UmWCElAwLdeKOuB4givmnIr2LJ9HHWW6soeh0D-lfAY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43682@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 378 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/43682#discussion_r1240742380

Comment:
This looks wrong, you are probably trying to target cross builds, not specific architectures which can be compiled either native or cross.

```
if [ "$CROSS_BUILD" ]; then
	hostmakedepends+=" qt5-qmake qt5-host-tools"
fi
```

  parent reply	other threads:[~2023-06-24 12:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-30 11:57 [PR PATCH] " sug0
2023-05-02 19:12 ` [PR PATCH] [Updated] " sug0
2023-05-02 19:12 ` sug0
2023-05-02 19:16 ` sug0
2023-05-02 19:21 ` sug0
2023-06-24 12:05 ` Duncaen [this message]
2023-06-26  8:43 ` sug0
2023-06-26  8:45 ` sug0
2023-06-26  8:59 ` sug0
2023-06-26  9:04 ` [PR PATCH] [Updated] New package: seer-2.0 sug0
2023-06-26 10:49 ` [PR PATCH] [Closed]: " Duncaen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230624120519.UmWCElAwLdeKOuB4givmnIr2LJ9HHWW6soeh0D-lfAY@z \
    --to=duncaen@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).