Re: [PR PATCH] [Updated] rubberband: update to 3.2.1, adopt.

[mhmdanas <mhmdanas@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]

There is an updated pull request by mhmdanas against master on the void-packages repository

https://github.com/mhmdanas/void-packages rubberband-3.2.1
https://github.com/void-linux/void-packages/pull/44215

rubberband: update to 3.2.1, adopt.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/44215.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rubberband-3.2.1-44215.patch --]
[-- Type: text/x-diff, Size: 3916 bytes --]

From 58df490f679cc1f2bf45ea7786baad4eb8296fba Mon Sep 17 00:00:00 2001
From: triallax <triallax@tutanota.com>
Date: Thu, 1 Jun 2023 18:23:04 +0100
Subject: [PATCH] rubberband: update to 3.2.1, adopt.

---
 ...6f472e3271ad64ab6c2968920e5e95c17080.patch | 26 +++++++++++++++++
 srcpkgs/rubberband/template                   | 29 +++++++++++++++----
 2 files changed, 50 insertions(+), 5 deletions(-)
 create mode 100644 srcpkgs/rubberband/patches/df596f472e3271ad64ab6c2968920e5e95c17080.patch

diff --git a/srcpkgs/rubberband/patches/df596f472e3271ad64ab6c2968920e5e95c17080.patch b/srcpkgs/rubberband/patches/df596f472e3271ad64ab6c2968920e5e95c17080.patch
new file mode 100644
index 000000000000..15d5150a48a7
--- /dev/null
+++ b/srcpkgs/rubberband/patches/df596f472e3271ad64ab6c2968920e5e95c17080.patch
@@ -0,0 +1,26 @@
+From df596f472e3271ad64ab6c2968920e5e95c17080 Mon Sep 17 00:00:00 2001
+From: Chris Cannam <cannam@all-day-breakfast.com>
+Date: Mon, 26 Jun 2023 11:38:20 +0100
+Subject: [PATCH] Minor threshold tweak
+
+---
+Remove on next release.
+
+Source: https://github.com/breakfastquay/rubberband/commit/df596f472e3271ad64ab6c2968920e5e95c17080
+
+ src/test/TestStretcher.cpp | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/test/TestStretcher.cpp b/src/test/TestStretcher.cpp
+index 8213dbe4..cbf3ae3c 100644
+--- a/src/test/TestStretcher.cpp
++++ b/src/test/TestStretcher.cpp
+@@ -999,7 +999,7 @@ static void impulses_realtime(RubberBandStretcher::Options options,
+     // These limits aren't alarming, but it may be worth tightening
+     // them and and taking a look at the waveforms
+     
+-    BOOST_TEST(peak0 < int(ceil(200 * timeRatio)));
++    BOOST_TEST(peak0 < int(ceil(210 * timeRatio)));
+     BOOST_TEST(peak0 > int(ceil(50 * timeRatio)));
+ 
+     BOOST_TEST(peak1 < int(ceil(5070 * timeRatio)));
diff --git a/srcpkgs/rubberband/template b/srcpkgs/rubberband/template
index 5d41a61ad7a5..8762aa8e99e6 100644
--- a/srcpkgs/rubberband/template
+++ b/srcpkgs/rubberband/template
@@ -1,22 +1,40 @@
 # Template file for 'rubberband'
 pkgname=rubberband
-version=3.1.2
+version=3.2.1
 revision=1
 build_style=meson
+configure_args="--buildtype=release -Dfft=fftw"
 hostmakedepends="pkg-config"
-makedepends="ladspa-sdk libsamplerate-devel vamp-plugin-sdk-devel fftw-devel lv2"
+makedepends="ladspa-sdk vamp-plugin-sdk-devel fftw-devel lv2"
 depends="libvamp-plugin-sdk"
+checkdepends="boost-devel"
 short_desc="Time-stretching and pitch-shifting audio library"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Mohammed Anas <triallax@tutanota.com>"
 license="GPL-2.0-or-later"
 homepage="https://breakfastquay.com/rubberband/"
 changelog="https://breakfastquay.com/news.html"
 distfiles="https://breakfastquay.com/files/releases/rubberband-${version}.tar.bz2"
-checksum=dda7e257b14c59a1f59c5ccc4d6f19412039f77834275955aa0ff511779b98d2
+checksum=82edacd0c50bfe56a6a85db1fcd4ca3346940ffe02843fc50f8b92f99a97d172
 
 if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
 	makedepends+=" libatomic-devel"
-	LDFLAGS+=" -latomic"
+	LDFLAGS="-latomic"
+fi
+
+# On 32-bit targets, the built-in resampler is much slower than libsamplerate.
+# On 64-bit targets the performance difference is not as pronounced, and the
+# built-in resampler can, in some situations, sound slightly better, so keep
+# using it on them.
+# See https://github.com/breakfastquay/rubberband/issues/87#issuecomment-1607722278.
+if [ "$XBPS_TARGET_WORDSIZE" = 32 ]; then
+	makedepends+=" libsamplerate-devel"
+	configure_args+=" -Dresampler=libsamplerate"
+fi
+
+if [ "$XBPS_CHECK_PKGS" ]; then
+	configure_args+=" -Dtests=enabled"
+else
+	configure_args+=" -Dtests=disabled"
 fi
 
 librubberband_package() {
@@ -27,6 +45,7 @@ librubberband_package() {
 		vmove usr/lib/ladspa
 	}
 }
+
 rubberband-devel_package() {
 	depends="librubberband>=${version}_${revision}"
 	short_desc+=" - Development files"