From: leahneukirchen <leahneukirchen@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Closed]: Switch to bitcoin-core libsecp256k1 and remove libbitcoin; update electrum, Electron-Cash
Date: Mon, 26 Jun 2023 22:07:35 +0200 [thread overview]
Message-ID: <20230626200735.bLqOBTInSK79DrDDeatCKJ4tcBzIQwM312FdkdCs4mY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43702@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 2097 bytes --]
There's a closed pull request on the void-packages repository
Switch to bitcoin-core libsecp256k1 and remove libbitcoin; update electrum, Electron-Cash
https://github.com/void-linux/void-packages/pull/43702
Description:
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### New package: libsecp256k1
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
Electrum v4.4.1 moved to using libsecp256k1 0.3.1 (`libsecp256k1.so.2`).
Void's current libsecp256k1 is from https://github.com/libbitcoin/secp256k1, which is extremely outdated.
I believe this was originally used because back then https://github.com/bitcoin-core/secp256k1 was too unstable and did not provide tagged releases. Now they do, so we should move to that.
The only two packages which use libsecp256k1 are `electrum` and `Electron-Cash` (besides the other `libbitcoin-*` packages).
Electron Cash can also use bitcoin-core's libsecp256k1 v0.3.1, although it actually needs https://github.com/Bitcoin-ABC/secp256k1 or Electron Cash's own fork for full functionality (CashFusion would not work):
> you CAN use the Core version, and it will speed-up ECDSA sigs.. but then for Schnorr sigs it won't speed them up at all since Core's Schnorr stuff differs from Bitcoin Cash's. So Electron Cash will detect that it's on Core, and will fall-back to using python-only Schnorr in that case (slow).
> https://github.com/Electron-Cash/Electron-Cash/issues/2596#issuecomment-1529926625
CashFusion is currently not working either since it's already using the wrong version of the library, so switching to bitcoin-core's libsecp256k1 v0.3.1 should be fine for Electron Cash too.
The other 10 libbitcoin packages which also depend on libsecp256k1 have been removed:
- libbitcoin-blockchain
- libbitcoin-client
- libbitcoin-consensus
- libbitcoin-database
- libbitcoin-explorer
- libbitcoin-network
- libbitcoin-node
- libbitcoin-protocol
- libbitcoin-server
- libbitcoin-system
prev parent reply other threads:[~2023-06-26 20:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-01 17:40 [PR PATCH] Switch to bitcoin-core/libsecp256k1 and remove libbitcoin? Update " ar-jan
2023-05-01 17:44 ` ar-jan
2023-05-01 18:53 ` ar-jan
2023-05-02 1:28 ` atweiden
2023-05-06 12:41 ` [PR PATCH] [Updated] " ar-jan
2023-05-06 12:54 ` ar-jan
2023-05-15 20:32 ` [PR PATCH] [Updated] Switch to bitcoin-core libsecp256k1 and remove libbitcoin; update " ar-jan
2023-05-15 20:56 ` ar-jan
2023-05-15 21:05 ` ar-jan
2023-05-16 18:14 ` [PR PATCH] [Updated] " ar-jan
2023-05-16 19:06 ` ar-jan
2023-05-21 13:31 ` [PR PATCH] [Updated] " ar-jan
2023-05-21 13:35 ` ar-jan
2023-06-26 20:07 ` leahneukirchen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230626200735.bLqOBTInSK79DrDDeatCKJ4tcBzIQwM312FdkdCs4mY@z \
--to=leahneukirchen@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).