[PR PATCH] transmission: don't use deprecated --log-error

[PR PATCH] transmission: don't use deprecated --log-error

[r-ricci]

[-- Attachment #1: Type: text/plain, Size: 1497 bytes --]

There is a new pull request by r-ricci against master on the void-packages repository

https://github.com/r-ricci/void-packages transmission
https://github.com/void-linux/void-packages/pull/44653

transmission: don't use deprecated --log-error
Even though the man page for transmission-daemon was not updated to reflect the change, `--log-error` has been deprecated by `--log-level=error` (see `transmission-daemon --help`).
A warning is logged if the old flag is used.


<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/44653.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-transmission-44653.patch --]
[-- Type: text/x-diff, Size: 1753 bytes --]

From 4b6949a6a23c216c4a811541008a00f9cf344798 Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Tue, 27 Jun 2023 00:33:57 +0200
Subject: [PATCH] transmission: don't use deprecated --log-error

Also link to system libraries when possible
---
 srcpkgs/transmission/files/transmission-daemon/run | 2 +-
 srcpkgs/transmission/template                      | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/transmission/files/transmission-daemon/run b/srcpkgs/transmission/files/transmission-daemon/run
index ed988af16556..6cdb40001497 100755
--- a/srcpkgs/transmission/files/transmission-daemon/run
+++ b/srcpkgs/transmission/files/transmission-daemon/run
@@ -1,3 +1,3 @@
 #!/bin/sh
 exec 2>&1
-exec chpst -u transmission:transmission transmission-daemon -f --log-error
+exec chpst -u transmission:transmission transmission-daemon -f --log-level=error
diff --git a/srcpkgs/transmission/template b/srcpkgs/transmission/template
index 3b9dc2e0cb7e..2e83bcdc11a3 100644
--- a/srcpkgs/transmission/template
+++ b/srcpkgs/transmission/template
@@ -1,13 +1,14 @@
 # Template file for 'transmission'
 pkgname=transmission
 version=4.0.3
-revision=1
+revision=2
 build_style=cmake
 configure_args="-DENABLE_CLI=ON -DENABLE_GTK=ON -DENABLE_QT=ON -DENABLE_MAC=OFF"
 hostmakedepends="autoconf automake intltool glib-devel
  libtool pkg-config qt5-host-tools qt5-qmake"
 makedepends="dbus-glib-devel gtkmm4-devel glibmm-devel
- libcurl-devel libevent-devel qt5-tools-devel qt5-svg-devel"
+ libcurl-devel libevent-devel qt5-tools-devel qt5-svg-devel
+ libdeflate-devel miniupnpc-devel"
 short_desc="Fast, easy and free BitTorrent client"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="MIT, GPL-2.0-or-later"

Re: [PR PATCH] [Merged]: transmission: don't use deprecated --log-error

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1341 bytes --]

There's a merged pull request on the void-packages repository

transmission: don't use deprecated --log-error
https://github.com/void-linux/void-packages/pull/44653

Description:
Even though the man page for transmission-daemon was not updated to reflect the change, `--log-error` has been deprecated by `--log-level=error` (see `transmission-daemon --help`).
A warning is logged if the old flag is used.


<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->