Github messages for voidlinux
 help / color / mirror / Atom feed
From: jason1987d <jason1987d@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] New package: python3-finvizfinance-0.14.5
Date: Tue, 27 Jun 2023 19:07:24 +0200	[thread overview]
Message-ID: <20230627170724.UBC0s0vgHTPnrTxPpPy7gpmdNtR7_RAaYp589H-D6ps@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-44201@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 774 bytes --]

There is an updated pull request by jason1987d against master on the void-packages repository

https://github.com/jason1987d/void-packages python3-finvizfinance
https://github.com/void-linux/void-packages/pull/44201

New package: python3-finvizfinance-0.14.5
#### Testing the changes
- I tested the changes in this PR: YES

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): YES


#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures (if supported. mark crossbuilds):


A patch file from https://github.com/void-linux/void-packages/pull/44201.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-finvizfinance-44201.patch --]
[-- Type: text/x-diff, Size: 3022 bytes --]

From 6f3242262b4c8165d6b586e504dd22c56fa49419 Mon Sep 17 00:00:00 2001
From: Jason Manley <jason@jasondavid.tv>
Date: Sun, 6 Nov 2022 17:06:40 -0600
Subject: [PATCH] New package: python3-finvizfinance-0.14.5

---
 .../patches/quote.py.patch                    | 31 +++++++++++++++++++
 srcpkgs/python3-finvizfinance/template        | 18 +++++++++++
 2 files changed, 49 insertions(+)
 create mode 100644 srcpkgs/python3-finvizfinance/patches/quote.py.patch
 create mode 100644 srcpkgs/python3-finvizfinance/template

diff --git a/srcpkgs/python3-finvizfinance/patches/quote.py.patch b/srcpkgs/python3-finvizfinance/patches/quote.py.patch
new file mode 100644
index 000000000000..8fad457ba40b
--- /dev/null
+++ b/srcpkgs/python3-finvizfinance/patches/quote.py.patch
@@ -0,0 +1,31 @@
+Wrap a test that was failing with exception handling in order to pass testing.
+https://github.com/lit26/finvizfinance/commit/ddd263736be278c8834242679c08c804d17ba1c0
+--- a/finvizfinance/quote.py	2023-02-03 21:17:45.000000000 -0600
++++ b/finvizfinance/quote.py	2023-05-29 17:56:18.702135822 -0500
+@@ -133,12 +133,20 @@
+         table = self.soup.find("table", class_="fullview-title")
+         rows = table.findAll("tr")
+ 
+-        fundament_info["Company"] = rows[1].text
+-        (
+-            fundament_info["Sector"],
+-            fundament_info["Industry"],
+-            fundament_info["Country"],
+-        ) = rows[2].text.split(" | ")
++        try:
++            fundament_info["Company"] = rows[1].text
++            (
++                fundament_info["Sector"],
++                fundament_info["Industry"],
++                fundament_info["Country"],
++            ) = rows[2].text.split(" | ")
++        except IndexError:
++            (_, fundament_info["Company"], _) = rows[0].text.split(' | ')
++            (
++                fundament_info["Sector"],
++                fundament_info["Industry"],
++                fundament_info["Country"],
++            ) = rows[1].text.split(" | ")
+ 
+         fundament_table = self.soup.find("table", class_="snapshot-table2")
+         rows = fundament_table.findAll("tr")
diff --git a/srcpkgs/python3-finvizfinance/template b/srcpkgs/python3-finvizfinance/template
new file mode 100644
index 000000000000..7402fd3d1b8b
--- /dev/null
+++ b/srcpkgs/python3-finvizfinance/template
@@ -0,0 +1,18 @@
+# Template file for 'python3-finvizfinance'
+pkgname=python3-finvizfinance
+version=0.14.5
+revision=1
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3 python3-requests python3-BeautifulSoup4 python3-pandas python3-lxml"
+checkdepends="${depends} python3-pytest python3-pytest-mock"
+short_desc="FinViz API Python 3 Module"
+maintainer="Jason Elswick <jason@jasondavid.tv>"
+license="MIT"
+homepage="https://pypi.org/project/finvizfinance/"
+distfiles="${PYPI_SITE}/f/finvizfinance/finvizfinance-${version}.tar.gz"
+checksum=c97fe0e69d681d9108113aed943988561665d0d4dbd64ffa0b666a2899c25899
+
+post_install() {
+	vlicense LICENSE
+}

  parent reply	other threads:[~2023-06-27 17:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-44201@inbox.vuxu.org>
2023-06-27 15:09 ` [PR REVIEW] " Duncaen
2023-06-27 15:29 ` [PR PATCH] [Updated] " jason1987d
2023-06-27 15:31 ` [PR REVIEW] " jason1987d
2023-06-27 15:43 ` Duncaen
2023-06-27 17:07 ` jason1987d [this message]
2023-06-27 17:33 ` jason1987d
2023-06-27 18:47 ` jason1987d
2023-06-27 19:42 ` jason1987d
2023-06-27 19:42 ` [PR PATCH] [Closed]: " jason1987d

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230627170724.UBC0s0vgHTPnrTxPpPy7gpmdNtR7_RAaYp589H-D6ps@z \
    --to=jason1987d@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).