From: xolophreny <xolophreny@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: eslauncher2-0.8.10
Date: Tue, 27 Jun 2023 19:15:50 +0200 [thread overview]
Message-ID: <20230627171550.FKIFrKleMr4A8pBrmUUE-e_XD6a8Ty-KfNzme1hIlAE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-41129@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 471 bytes --]
New review comment by xolophreny on void-packages repository
https://github.com/void-linux/void-packages/pull/41129#discussion_r1244092840
Comment:
Because one of the cargo crates this uses, `prost`, with itself ships a pre-built `protoc` binary that it needs, and that works on glibc but, despite them providing musl binaries, fails on musl. So that replaces it with the packaged version. Should it be put in regular `hostmakedepends` so it doesn't look as confusing?
next prev parent reply other threads:[~2023-06-27 17:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 6:19 [PR PATCH] New package: eslauncher2-0.8.6 xolophreny
2022-12-16 6:48 ` [PR PATCH] [Updated] " xolophreny
2022-12-18 22:58 ` xolophreny
2022-12-18 23:16 ` xolophreny
2022-12-18 23:20 ` xolophreny
2022-12-18 23:58 ` [PR PATCH] [Updated] " xolophreny
2023-01-31 19:03 ` xolophreny
2023-02-21 21:41 ` [PR PATCH] [Updated] New package: eslauncher2-0.8.7 xolophreny
2023-03-09 17:27 ` [PR PATCH] [Updated] New package: eslauncher2-0.8.9 xolophreny
2023-06-08 2:04 ` New package: eslauncher2-0.8.10 github-actions
2023-06-14 13:28 ` xolophreny
2023-06-24 13:18 ` [PR REVIEW] " Duncaen
2023-06-27 17:15 ` xolophreny [this message]
2023-06-27 17:17 ` Duncaen
2023-06-28 23:06 ` [PR PATCH] [Updated] " xolophreny
2023-06-28 23:16 ` xolophreny
2023-07-06 17:27 ` xolophreny
2023-10-05 1:46 ` github-actions
2023-10-20 1:45 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230627171550.FKIFrKleMr4A8pBrmUUE-e_XD6a8Ty-KfNzme1hIlAE@z \
--to=xolophreny@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).