Re: [PR PATCH] [Updated] New package: logiops-0.2.3

[T0mstone <T0mstone@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]

There is an updated pull request by T0mstone against master on the void-packages repository

https://github.com/T0mstone/void-packages logiops
https://github.com/void-linux/void-packages/pull/42849

New package: logiops-0.2.3
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/42849.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-logiops-42849.patch --]
[-- Type: text/x-diff, Size: 3637 bytes --]

From 0b72e7f77bc027bc27bcdd79e97db56ec555be7a Mon Sep 17 00:00:00 2001
From: T0mstone <realt0mstone@gmail.com>
Date: Sat, 18 Mar 2023 22:36:22 +0100
Subject: [PATCH 1/2] New package: logiops-0.2.3

---
 srcpkgs/logiops/files/logid.cfg |  1 +
 srcpkgs/logiops/files/logid/run |  7 +++++++
 srcpkgs/logiops/template        | 24 ++++++++++++++++++++++++
 3 files changed, 32 insertions(+)
 create mode 100644 srcpkgs/logiops/files/logid.cfg
 create mode 100644 srcpkgs/logiops/files/logid/run
 create mode 100644 srcpkgs/logiops/template

diff --git a/srcpkgs/logiops/files/logid.cfg b/srcpkgs/logiops/files/logid.cfg
new file mode 100644
index 000000000000..76be54d61e23
--- /dev/null
+++ b/srcpkgs/logiops/files/logid.cfg
@@ -0,0 +1 @@
+devices: ();
\ No newline at end of file
diff --git a/srcpkgs/logiops/files/logid/run b/srcpkgs/logiops/files/logid/run
new file mode 100644
index 000000000000..c99363c7ea18
--- /dev/null
+++ b/srcpkgs/logiops/files/logid/run
@@ -0,0 +1,7 @@
+#!/bin/sh
+if /usr/bin/modprobe hid_logitech_hidpp
+then exec /usr/bin/logid
+else
+	# retry every second until the module is loaded
+	sleep 1
+fi
\ No newline at end of file
diff --git a/srcpkgs/logiops/template b/srcpkgs/logiops/template
new file mode 100644
index 000000000000..86b570c094f5
--- /dev/null
+++ b/srcpkgs/logiops/template
@@ -0,0 +1,24 @@
+# Template file for 'logiops'
+pkgname=logiops
+version=0.2.3
+revision=1
+build_style=cmake
+make_cmd=make
+hostmakedepends="gcc make cmake pkg-config"
+makedepends="libevdev-devel eudev-libudev-devel libconfig-devel libconfig++-devel"
+short_desc="Unofficial userspace driver for HID++ Logitech devices"
+maintainer="T0mstone <realt0mstone@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/PixlOne/logiops"
+changelog="https://github.com/PixlOne/logiops/releases/tag/v${version}"
+distfiles="https://github.com/PixlOne/logiops/archive/refs/tags/v${version}.tar.gz"
+checksum=45147cacc5e75d461fa53e6f391aa6994cc724a422d1a8f8943e50186854f88f
+conf_files="/etc/logid.cfg"
+
+export CMAKE_GENERATOR="Unix Makefiles"
+
+post_install() {
+	vsconf logid.example.cfg logid.cfg
+	vconf $FILESDIR/logid.cfg
+	vsv logid
+}

From e61948595dc59503c0f44512016abb07c19bc037 Mon Sep 17 00:00:00 2001
From: T0mstone <realt0mstone@gmail.com>
Date: Wed, 28 Jun 2023 19:21:43 +0200
Subject: [PATCH 2/2] address complaints

---
 srcpkgs/logiops/files/logid.cfg | 1 -
 srcpkgs/logiops/files/logid/run | 9 +++------
 srcpkgs/logiops/template        | 1 -
 3 files changed, 3 insertions(+), 8 deletions(-)
 delete mode 100644 srcpkgs/logiops/files/logid.cfg

diff --git a/srcpkgs/logiops/files/logid.cfg b/srcpkgs/logiops/files/logid.cfg
deleted file mode 100644
index 76be54d61e23..000000000000
--- a/srcpkgs/logiops/files/logid.cfg
+++ /dev/null
@@ -1 +0,0 @@
-devices: ();
\ No newline at end of file
diff --git a/srcpkgs/logiops/files/logid/run b/srcpkgs/logiops/files/logid/run
index c99363c7ea18..30542ccf311f 100644
--- a/srcpkgs/logiops/files/logid/run
+++ b/srcpkgs/logiops/files/logid/run
@@ -1,7 +1,4 @@
 #!/bin/sh
-if /usr/bin/modprobe hid_logitech_hidpp
-then exec /usr/bin/logid
-else
-	# retry every second until the module is loaded
-	sleep 1
-fi
\ No newline at end of file
+[ -r conf ] && . ./conf
+modprobe -q hid_logitech_hidpp || exit 1
+exec logid ${OPTS}
diff --git a/srcpkgs/logiops/template b/srcpkgs/logiops/template
index 86b570c094f5..7de956775ae9 100644
--- a/srcpkgs/logiops/template
+++ b/srcpkgs/logiops/template
@@ -19,6 +19,5 @@ export CMAKE_GENERATOR="Unix Makefiles"
 
 post_install() {
 	vsconf logid.example.cfg logid.cfg
-	vconf $FILESDIR/logid.cfg
 	vsv logid
 }