[PR PATCH] common/build-style/gnu-makefile.sh: pass ${makejobs} to install target.

[PR PATCH] common/build-style/gnu-makefile.sh: pass ${makejobs} to install target.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 1342 bytes --]

There is a new pull request by mhmdanas against master on the void-packages repository

https://github.com/mhmdanas/void-packages pass-makejobs-to-install-gnu-makefile
https://github.com/void-linux/void-packages/pull/44596

common/build-style/gnu-makefile.sh: pass ${makejobs} to install target.
Some software compile stuff in the install step.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/44596.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pass-makejobs-to-install-gnu-makefile-44596.patch --]
[-- Type: text/x-diff, Size: 922 bytes --]

From 0b61b534b3fd3b4ff67a8cd6e18b5090ef38a14d Mon Sep 17 00:00:00 2001
From: triallax <triallax@tutanota.com>
Date: Fri, 23 Jun 2023 19:35:29 +0100
Subject: [PATCH] common/build-style/gnu-makefile.sh: pass ${makejobs} to
 install target.

Some software compile stuff in the install step.
---
 common/build-style/gnu-makefile.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/build-style/gnu-makefile.sh b/common/build-style/gnu-makefile.sh
index c4f4f780f9f6..36ded5fcd3ba 100644
--- a/common/build-style/gnu-makefile.sh
+++ b/common/build-style/gnu-makefile.sh
@@ -39,5 +39,5 @@ do_install() {
 	: ${make_cmd:=make}
 	: ${make_install_target:=install}
 
-	${make_cmd} STRIP=true PREFIX=/usr prefix=/usr DESTDIR=${DESTDIR} ${make_install_args} ${make_install_target}
+	${make_cmd} STRIP=true PREFIX=/usr prefix=/usr DESTDIR=${DESTDIR} ${make_install_args} ${make_install_target} ${makejobs}
 }

Re: common/build-style/gnu-makefile.sh: pass ${makejobs} to install target.

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/44596#issuecomment-1604776484

Comment:
The software should not compile stuff at the install step, this usually breaks things since the make invocations have different argument and environment variables.

Re: common/build-style/gnu-makefile.sh: pass ${makejobs} to install target.

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/44596#issuecomment-1604776484

Comment:
The software should not compile stuff at the install step, this usually breaks things since the make invocations have different arguments and environment variables.

Re: common/build-style/gnu-makefile.sh: pass ${makejobs} to install target.

[sgn]

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/44596#issuecomment-1613436255

Comment:
Yes, those packages that compile during `do_install` should be fixed.

Re: common/build-style/gnu-makefile.sh: pass ${makejobs} to install target.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/44596#issuecomment-1618917112

Comment:
Makes sense, I submitted this because `nodejs` builds stuff in its install step, which I thought some other software may be doing too (though the `nodejs` template itself doesn't use the `gnu-makefile` build style).

Re: [PR PATCH] [Closed]: common/build-style/gnu-makefile.sh: pass ${makejobs} to install target.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 1159 bytes --]

There's a closed pull request on the void-packages repository

common/build-style/gnu-makefile.sh: pass ${makejobs} to install target.
https://github.com/void-linux/void-packages/pull/44596

Description:
Some software compile stuff in the install step.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->