Re: [PR PATCH] [Updated] [RFC] base-files: add kernel hook for /boot freespace

[abenson <abenson@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]

There is an updated pull request by abenson against master on the void-packages repository

https://github.com/abenson/void-packages kernel_bootsize_hook
https://github.com/void-linux/void-packages/pull/44137

[RFC] base-files: add kernel hook for /boot freespace
    <leah2> we should make a kernel install hook check that prints a big
            warning if /boot is full after running it...

Thoughts:

1. Change the threshold size? Make it configurable?
2. Change the threshold to a percentage? I think that's less useful.
3. Change what package this is shipped with? I'm not sure if it applies to all configurations we support/consider.
4. Wording of the message?

A patch file from https://github.com/void-linux/void-packages/pull/44137.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kernel_bootsize_hook-44137.patch --]
[-- Type: text/x-diff, Size: 2805 bytes --]

From 33cb87ebcb78a5fdfe33c0bd041d488d3ffd4c99 Mon Sep 17 00:00:00 2001
From: Andrew Benson <abenson+void@gmail.com>
Date: Mon, 29 May 2023 13:55:46 -0500
Subject: [PATCH] linux-base: post-install hook for /boot freespace

Co-authored-by: classabbyamp <5366828+classabbyamp@users.noreply.github.com>
---
 srcpkgs/linux-base/files/50-bootsize.postinst | 38 +++++++++++++++++++
 srcpkgs/linux-base/template                   |  7 +++-
 2 files changed, 43 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/linux-base/files/50-bootsize.postinst

diff --git a/srcpkgs/linux-base/files/50-bootsize.postinst b/srcpkgs/linux-base/files/50-bootsize.postinst
new file mode 100644
index 000000000000..1fe95c9511bb
--- /dev/null
+++ b/srcpkgs/linux-base/files/50-bootsize.postinst
@@ -0,0 +1,38 @@
+#!/bin/sh
+#
+# Kernel hook to check for filled /boot partitions
+#
+# Arguments passed to this script: $1 pkgname, $2 version.
+#
+PKGNAME="$1"
+VERSION="$2"
+
+# freespace = blocksize * freeblocks
+freespace=$(( $(stat -f -c '%S * %f' /boot) ))
+
+vmlinuz=$(find /boot -maxdepth 1 -type f -name 'vmlinuz*' -printf '%s\n' | sort -n | tail -n1)
+initramfs=$(find /boot -maxdepth 1 -type f -name 'initramfs*' -printf '%s\n' | sort -n | tail -n1)
+totalneeded=$(( 2 * (initramfs + vmlinuz) ))
+
+# freespace for /boot is <=  2*(largest kernel + largest initrd)
+if [ $freespace -le $totalneeded ]; then
+	color=false
+	if [ -z "$NO_COLOR" ] && [ -t 1 ]; then
+		# Set output to be bold and red, if supported
+		color=true
+		tput setaf 1
+		tput bold
+	fi
+	cat <<-'ENDMSG'
+	 * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
+	 * WARNING: /boot may not have enough space for the next kernel. Use     *
+	 * `vkpurge` to ensure there will be sufficient space to write the next  *
+	 * kernel and generate its initrd. Your system may otherwise become      *
+	 * unbootable.                                                           *
+	 * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
+	ENDMSG
+	if $color; then
+		# Reset output back to normal
+		tput sgr0
+	fi
+fi
diff --git a/srcpkgs/linux-base/template b/srcpkgs/linux-base/template
index 249f21fa27f2..d04e7ad12bb6 100644
--- a/srcpkgs/linux-base/template
+++ b/srcpkgs/linux-base/template
@@ -1,8 +1,7 @@
 # Template file for 'linux-base'
 pkgname=linux-base
-version=2021.07.21
+version=2023.05.29
 revision=1
-build_style=meta
 short_desc="Linux kernel base dependencies"
 maintainer="Érico Nogueira <ericonr@disroot.org>"
 license="Public Domain"
@@ -16,3 +15,7 @@ case "$XBPS_TARGET_MACHINE" in
 		depends="linux-firmware-amd linux-firmware-nvidia linux-firmware-network dracut"
 		;;
 esac
+
+do_install() {
+	vinstall ${FILESDIR}/50-bootsize.postinst 0755 etc/kernel.d/post-install 50-bootsize
+}