From: fgietzen <fgietzen@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] remmina: compile with kwallet support
Date: Tue, 04 Jul 2023 20:30:14 +0200 [thread overview]
Message-ID: <20230704183014.wahRcyPUT6wlmLvRNYzI1VfBYR6gCjWnRIH2RCdXBZg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-44677@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 802 bytes --]
There is an updated pull request by fgietzen against master on the void-packages repository
https://github.com/fgietzen/void-packages master
https://github.com/void-linux/void-packages/pull/44677
remmina: compile with kwallet support
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### Local build testing
- I built this PR locally for my native architecture, x86_64
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- x86_64-musl
- aarch64
### Description
Adds compile flag and dependency to support *KWallet* in Remmina so passwords can be stored.
A patch file from https://github.com/void-linux/void-packages/pull/44677.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-44677.patch --]
[-- Type: text/x-diff, Size: 1954 bytes --]
From 34008c103992754ef244610d94835eb37fd274f8 Mon Sep 17 00:00:00 2001
From: Fabian Gietzen <fabian.gietzen@web.de>
Date: Wed, 28 Jun 2023 12:31:54 +0200
Subject: [PATCH] remmina: compile with kwallet support
---
srcpkgs/remmina-kwallet | 1 +
srcpkgs/remmina/template | 16 ++++++++++++----
2 files changed, 13 insertions(+), 4 deletions(-)
create mode 120000 srcpkgs/remmina-kwallet
diff --git a/srcpkgs/remmina-kwallet b/srcpkgs/remmina-kwallet
new file mode 120000
index 000000000000..88b1c3eacfbf
--- /dev/null
+++ b/srcpkgs/remmina-kwallet
@@ -0,0 +1 @@
+remmina
\ No newline at end of file
diff --git a/srcpkgs/remmina/template b/srcpkgs/remmina/template
index 657e392d1f01..7c89e4e0e968 100644
--- a/srcpkgs/remmina/template
+++ b/srcpkgs/remmina/template
@@ -1,12 +1,12 @@
# Template file for 'remmina'
pkgname=remmina
version=1.4.31
-revision=1
+revision=2
build_style=cmake
-configure_args="-DCMAKE_USE_PTHREADS_INIT=ON"
-hostmakedepends="glib-devel intltool pkg-config shared-mime-info"
+configure_args="-DCMAKE_USE_PTHREADS_INIT=ON -DWITH_KF5WALLET=on"
+hostmakedepends="glib-devel intltool pkg-config shared-mime-info qt5-host-tools qt5-qmake"
makedepends="avahi-glib-libs-devel avahi-ui-libs-devel freerdp-devel
- gobject-introspection gstreamermm-devel json-glib-devel
+ gobject-introspection gstreamermm-devel json-glib-devel kwallet-devel
libgcrypt-devel libgnome-keyring-devel liblz4-devel libsasl-devel
libsecret-devel libsodium-devel libsoup3-devel libssh-devel libva-devel
libvncserver-devel libxkbfile-devel opus-devel phodav-devel
@@ -24,3 +24,11 @@ checksum=cfe9d4a6f2951d35533e5b2235f76640573c91f1be3bd8118637fbf68234500a
if [ "$XBPS_TARGET_LIBC" = "musl" ]; then
makedepends+=" libexecinfo-devel"
fi
+
+remmina-kwallet_package() {
+ short_desc+=" - kwallet plugin"
+ depends="${sourcepkg}>=${version}_${revision} kwallet"
+ pkg_install() {
+ vmove usr/lib/remmina/plugins/remmina-plugin-kwallet.so
+ }
+}
next prev parent reply other threads:[~2023-07-04 18:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 10:49 [PR PATCH] " fgietzen
2023-06-29 10:50 ` [PR PATCH] [Updated] " fgietzen
2023-06-29 15:44 ` [PR REVIEW] " sgn
2023-06-29 16:25 ` [PR PATCH] [Updated] " fgietzen
2023-06-29 16:26 ` [PR REVIEW] " fgietzen
2023-07-04 16:34 ` sgn
2023-07-04 18:30 ` fgietzen [this message]
2023-07-04 18:38 ` fgietzen
2023-07-17 2:57 ` [PR PATCH] [Merged]: " sgn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230704183014.wahRcyPUT6wlmLvRNYzI1VfBYR6gCjWnRIH2RCdXBZg@z \
--to=fgietzen@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).