Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] doomretro: rebuild with newer SDL2
@ 2023-07-09  9:08 benalb
  2023-07-10  8:51 ` classabbyamp
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: benalb @ 2023-07-09  9:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]

There is a new pull request by benalb against master on the void-packages repository

https://github.com/benalb/void-packages doomretro
https://github.com/void-linux/void-packages/pull/44937

doomretro: rebuild with newer SDL2
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (X86_64-LIBC)


A patch file from https://github.com/void-linux/void-packages/pull/44937.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-doomretro-44937.patch --]
[-- Type: text/x-diff, Size: 695 bytes --]

From 9a55b272421648581dc0a4344ef768d4d1747473 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Benjam=C3=ADn=20Albi=C3=B1ana?= <benalb@gmail.com>
Date: Sun, 9 Jul 2023 11:06:56 +0200
Subject: [PATCH] doomretro: rebuild with newer SDL2

---
 srcpkgs/doomretro/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/doomretro/template b/srcpkgs/doomretro/template
index 40c9bbd43882..af78a6e75c93 100644
--- a/srcpkgs/doomretro/template
+++ b/srcpkgs/doomretro/template
@@ -1,7 +1,7 @@
 # Template file for 'doomretro'
 pkgname=doomretro
 version=4.9.2
-revision=1
+revision=2
 build_style=cmake
 hostmakedepends="pkg-config"
 makedepends="SDL2_image-devel SDL2_mixer-devel"

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: doomretro: rebuild with newer SDL2
  2023-07-09  9:08 [PR PATCH] doomretro: rebuild with newer SDL2 benalb
@ 2023-07-10  8:51 ` classabbyamp
  2023-07-10 13:53 ` benalb
  2023-07-10 16:38 ` [PR PATCH] [Merged]: " classabbyamp
  2 siblings, 0 replies; 4+ messages in thread
From: classabbyamp @ 2023-07-10  8:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/44937#issuecomment-1628524398

Comment:
does this fix some issue/crash?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: doomretro: rebuild with newer SDL2
  2023-07-09  9:08 [PR PATCH] doomretro: rebuild with newer SDL2 benalb
  2023-07-10  8:51 ` classabbyamp
@ 2023-07-10 13:53 ` benalb
  2023-07-10 16:38 ` [PR PATCH] [Merged]: " classabbyamp
  2 siblings, 0 replies; 4+ messages in thread
From: benalb @ 2023-07-10 13:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 282 bytes --]

New comment by benalb on void-packages repository

https://github.com/void-linux/void-packages/pull/44937#issuecomment-1629016074

Comment:
> does this fix some issue/crash?

yes, without rebuilding it, doomretro does not work, with an error pointing to the SDL version mismatch.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Merged]: doomretro: rebuild with newer SDL2
  2023-07-09  9:08 [PR PATCH] doomretro: rebuild with newer SDL2 benalb
  2023-07-10  8:51 ` classabbyamp
  2023-07-10 13:53 ` benalb
@ 2023-07-10 16:38 ` classabbyamp
  2 siblings, 0 replies; 4+ messages in thread
From: classabbyamp @ 2023-07-10 16:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 956 bytes --]

There's a merged pull request on the void-packages repository

doomretro: rebuild with newer SDL2
https://github.com/void-linux/void-packages/pull/44937

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (X86_64-LIBC)


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-07-10 16:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-09  9:08 [PR PATCH] doomretro: rebuild with newer SDL2 benalb
2023-07-10  8:51 ` classabbyamp
2023-07-10 13:53 ` benalb
2023-07-10 16:38 ` [PR PATCH] [Merged]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).