[PR PATCH] New package: spnavcfg-1.1-1

[PR PATCH] New package: spnavcfg-1.1-1

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 741 bytes --]

There is a new pull request by CtrlC-Root against master on the void-packages repository

https://github.com/CtrlC-Root/void-packages spnavcfg
https://github.com/void-linux/void-packages/pull/44971

New package: spnavcfg-1.1-1
#### Testing the changes
- I tested the changes in this PR: **YES**

With the following:
* libspnav-1.1_1
* 3DConnexion SpaceMouse Pro Wireless

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64


A patch file from https://github.com/void-linux/void-packages/pull/44971.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-spnavcfg-44971.patch --]
[-- Type: text/x-diff, Size: 1160 bytes --]

From 1d6c11f400e5d9724f2773201ed994a5364f80ff Mon Sep 17 00:00:00 2001
From: Alexandru Barbur <alex@ctrlc.name>
Date: Sun, 9 Jul 2023 21:39:53 -0400
Subject: [PATCH] New package: spnavcfg-1.1-1

---
 srcpkgs/spnavcfg/template | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 srcpkgs/spnavcfg/template

diff --git a/srcpkgs/spnavcfg/template b/srcpkgs/spnavcfg/template
new file mode 100644
index 000000000000..1ea0eea3212e
--- /dev/null
+++ b/srcpkgs/spnavcfg/template
@@ -0,0 +1,15 @@
+# Template file for 'spnavcfg'
+pkgname=spnavcfg
+version=1.1
+revision=1
+build_style=gnu-configure
+hostmakedepends="pkg-config"
+makedepends="libspnav-devel qt5-devel"
+depends="libspnav qt5-core qt5-gui qt5-widgets"
+short_desc="Spacenav interactive configuration GUI"
+maintainer="Alexandru Barbur <alex@ctrlc.name>"
+license="GPL-3.0-or-later"
+homepage="http://spacenav.sourceforge.net"
+changelog="https://github.com/FreeSpacenav/spnavcfg/releases"
+distfiles="https://github.com/FreeSpacenav/spnavcfg/releases/download/v${version}/${pkgname}-${version}.tar.gz"
+checksum="02dfd91d6d761185baffa5e695515cdb64f3e26d2dc3abe790d6452163c75392"

Re: New package: spnavcfg-1.1-1

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

New comment by CtrlC-Root on void-packages repository

https://github.com/void-linux/void-packages/pull/44971#issuecomment-1629348164

Comment:
Hmm some of these architectures are failing because the `uic` binary provided by `qt5-host-tools` is missing. Which is odd because at least on x86_64 `qt5-devel` has a dependency on `qt5-host-tools`. Let me investigate this a bit.

Re: New package: spnavcfg-1.1-1

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 493 bytes --]

New comment by CtrlC-Root on void-packages repository

https://github.com/void-linux/void-packages/pull/44971#issuecomment-1629410575

Comment:
Actually I think this is a cross compilation issue. I can verify the `uic` binary is available (ex. `./masterdir/usr/aarch64-linux-gnu/usr/lib/qt5/bin/uic`) but I can't figure out how to either adjust the `PATH` environment variable to include it or detect it in the package template file to pass to the Makefile via the `UIC` environment variable.

Re: [PR PATCH] [Updated] New package: spnavcfg-1.1-1

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 746 bytes --]

There is an updated pull request by CtrlC-Root against master on the void-packages repository

https://github.com/CtrlC-Root/void-packages spnavcfg
https://github.com/void-linux/void-packages/pull/44971

New package: spnavcfg-1.1-1
#### Testing the changes
- I tested the changes in this PR: **YES**

With the following:
* libspnav-1.1_1
* 3DConnexion SpaceMouse Pro Wireless

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64


A patch file from https://github.com/void-linux/void-packages/pull/44971.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-spnavcfg-44971.patch --]
[-- Type: text/x-diff, Size: 1175 bytes --]

From de1604565ce887ef22f09456e33a5a2b71535b73 Mon Sep 17 00:00:00 2001
From: Alexandru Barbur <alex@ctrlc.name>
Date: Sun, 9 Jul 2023 21:39:53 -0400
Subject: [PATCH] New package: spnavcfg-1.1-1

---
 srcpkgs/spnavcfg/template | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 srcpkgs/spnavcfg/template

diff --git a/srcpkgs/spnavcfg/template b/srcpkgs/spnavcfg/template
new file mode 100644
index 000000000000..4987588ebe78
--- /dev/null
+++ b/srcpkgs/spnavcfg/template
@@ -0,0 +1,15 @@
+# Template file for 'spnavcfg'
+pkgname=spnavcfg
+version=1.1
+revision=1
+build_style=gnu-configure
+hostmakedepends="pkg-config qt5-host-tools"
+makedepends="libspnav-devel qt5-devel"
+depends="libspnav qt5-core qt5-gui qt5-widgets"
+short_desc="Spacenav interactive configuration GUI"
+maintainer="Alexandru Barbur <alex@ctrlc.name>"
+license="GPL-3.0-or-later"
+homepage="http://spacenav.sourceforge.net"
+changelog="https://github.com/FreeSpacenav/spnavcfg/releases"
+distfiles="https://github.com/FreeSpacenav/spnavcfg/releases/download/v${version}/${pkgname}-${version}.tar.gz"
+checksum="02dfd91d6d761185baffa5e695515cdb64f3e26d2dc3abe790d6452163c75392"

Re: New package: spnavcfg-1.1-1

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

New comment by CtrlC-Root on void-packages repository

https://github.com/void-linux/void-packages/pull/44971#issuecomment-1629414014

Comment:
Ok I added `qt5-host-tools` to `hostmakedepends` and that seems to have fixed the build. I'm not sure if this is the correct way to do this though.

Re: [PR REVIEW] New package: spnavcfg-1.1-1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/44971#discussion_r1258669836

Comment:
some of these may be autodetected

Re: [PR REVIEW] New package: spnavcfg-1.1-1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 282 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/44971#discussion_r1258669967

Comment:
```suggestion
distfiles="https://github.com/FreeSpacenav/spnavcfg/releases/download/v${version}/spnavcfg-${version}.tar.gz"
```

Re: [PR PATCH] [Updated] New package: spnavcfg-1.1-1

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 746 bytes --]

There is an updated pull request by CtrlC-Root against master on the void-packages repository

https://github.com/CtrlC-Root/void-packages spnavcfg
https://github.com/void-linux/void-packages/pull/44971

New package: spnavcfg-1.1-1
#### Testing the changes
- I tested the changes in this PR: **YES**

With the following:
* libspnav-1.1_1
* 3DConnexion SpaceMouse Pro Wireless

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64


A patch file from https://github.com/void-linux/void-packages/pull/44971.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-spnavcfg-44971.patch --]
[-- Type: text/x-diff, Size: 1173 bytes --]

From e462fc35ebda39fe2cf10d63b5423f1d03d4a0a0 Mon Sep 17 00:00:00 2001
From: Alexandru Barbur <alex@ctrlc.name>
Date: Sun, 9 Jul 2023 21:39:53 -0400
Subject: [PATCH] New package: spnavcfg-1.1-1

---
 srcpkgs/spnavcfg/template | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 srcpkgs/spnavcfg/template

diff --git a/srcpkgs/spnavcfg/template b/srcpkgs/spnavcfg/template
new file mode 100644
index 000000000000..eff8d62eb96e
--- /dev/null
+++ b/srcpkgs/spnavcfg/template
@@ -0,0 +1,15 @@
+# Template file for 'spnavcfg'
+pkgname=spnavcfg
+version=1.1
+revision=1
+build_style=gnu-configure
+hostmakedepends="pkg-config qt5-host-tools"
+makedepends="libspnav-devel qt5-devel"
+depends="libspnav qt5-core qt5-gui qt5-widgets"
+short_desc="Spacenav interactive configuration GUI"
+maintainer="Alexandru Barbur <alex@ctrlc.name>"
+license="GPL-3.0-or-later"
+homepage="http://spacenav.sourceforge.net"
+changelog="https://github.com/FreeSpacenav/spnavcfg/releases"
+distfiles="https://github.com/FreeSpacenav/spnavcfg/releases/download/v${version}/spnavcfg-${version}.tar.gz"
+checksum="02dfd91d6d761185baffa5e695515cdb64f3e26d2dc3abe790d6452163c75392"

Re: [PR REVIEW] New package: spnavcfg-1.1-1

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 400 bytes --]

New review comment by CtrlC-Root on void-packages repository

https://github.com/void-linux/void-packages/pull/44971#discussion_r1259951791

Comment:
Fixed in https://github.com/void-linux/void-packages/commit/e462fc35ebda39fe2cf10d63b5423f1d03d4a0a0. I went back and forth on this and found examples of packages which do both haha. I'm guessing the rule here is to only template the `version` part?

Re: [PR REVIEW] New package: spnavcfg-1.1-1

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

New review comment by CtrlC-Root on void-packages repository

https://github.com/void-linux/void-packages/pull/44971#discussion_r1259951953

Comment:
Waiting for feedback at https://github.com/void-linux/void-packages/pull/44959#discussion_r1259948835 and then I'll address this.

Re: [PR PATCH] [Updated] New package: spnavcfg-1.1-1

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 746 bytes --]

There is an updated pull request by CtrlC-Root against master on the void-packages repository

https://github.com/CtrlC-Root/void-packages spnavcfg
https://github.com/void-linux/void-packages/pull/44971

New package: spnavcfg-1.1-1
#### Testing the changes
- I tested the changes in this PR: **YES**

With the following:
* libspnav-1.1_1
* 3DConnexion SpaceMouse Pro Wireless

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64


A patch file from https://github.com/void-linux/void-packages/pull/44971.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-spnavcfg-44971.patch --]
[-- Type: text/x-diff, Size: 1123 bytes --]

From a9e1cf978d63c9df85fd5014bef3ba18733af592 Mon Sep 17 00:00:00 2001
From: Alexandru Barbur <alex@ctrlc.name>
Date: Sun, 9 Jul 2023 21:39:53 -0400
Subject: [PATCH] New package: spnavcfg-1.1-1

---
 srcpkgs/spnavcfg/template | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 srcpkgs/spnavcfg/template

diff --git a/srcpkgs/spnavcfg/template b/srcpkgs/spnavcfg/template
new file mode 100644
index 000000000000..af4b6e8783ad
--- /dev/null
+++ b/srcpkgs/spnavcfg/template
@@ -0,0 +1,14 @@
+# Template file for 'spnavcfg'
+pkgname=spnavcfg
+version=1.1
+revision=1
+build_style=gnu-configure
+hostmakedepends="pkg-config qt5-host-tools"
+makedepends="libspnav-devel qt5-devel"
+short_desc="Spacenav interactive configuration GUI"
+maintainer="Alexandru Barbur <alex@ctrlc.name>"
+license="GPL-3.0-or-later"
+homepage="http://spacenav.sourceforge.net"
+changelog="https://github.com/FreeSpacenav/spnavcfg/releases"
+distfiles="https://github.com/FreeSpacenav/spnavcfg/releases/download/v${version}/spnavcfg-${version}.tar.gz"
+checksum="02dfd91d6d761185baffa5e695515cdb64f3e26d2dc3abe790d6452163c75392"

Re: [PR REVIEW] New package: spnavcfg-1.1-1

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New review comment by CtrlC-Root on void-packages repository

https://github.com/void-linux/void-packages/pull/44971#discussion_r1259984022

Comment:
Fixed in https://github.com/void-linux/void-packages/commit/a9e1cf978d63c9df85fd5014bef3ba18733af592.

Re: [PR PATCH] [Merged]: New package: spnavcfg-1.1-1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 583 bytes --]

There's a merged pull request on the void-packages repository

New package: spnavcfg-1.1-1
https://github.com/void-linux/void-packages/pull/44971

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

With the following:
* libspnav-1.1_1
* 3DConnexion SpaceMouse Pro Wireless

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64