From: CtrlC-Root <CtrlC-Root@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: spacenavd-1.2-1
Date: Tue, 11 Jul 2023 17:58:55 +0200 [thread overview]
Message-ID: <20230711155855.zb-3pje--m63UUCwaWFfoqtUFvZQ5tKe8Rj8qJwnfJ8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-44959@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 741 bytes --]
New review comment by CtrlC-Root on void-packages repository
https://github.com/void-linux/void-packages/pull/44959#discussion_r1259948835
Comment:
I spent some time digging into the XBPS scripts that do this. Yeah it does seem like it would likely detect this dependency correctly. Do you have any thoughts or preferences on whether any automatically detected dependencies should still be listed here? Should I always omit ones that can be autodetected? I'm asking because you left similar feedback on a different PR (for spnavcfg) so I want to learn the rule and apply it everywhere going forward. I'm tempted to put dependencies that I know up front into this variable as a form of documentation but I'll do whatever you think is best.
next prev parent reply other threads:[~2023-07-11 15:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 14:08 [PR PATCH] " CtrlC-Root
2023-07-10 18:11 ` [PR REVIEW] " classabbyamp
2023-07-10 18:11 ` classabbyamp
2023-07-10 18:11 ` classabbyamp
2023-07-10 18:11 ` classabbyamp
2023-07-11 15:56 ` [PR PATCH] [Updated] " CtrlC-Root
2023-07-11 15:56 ` [PR REVIEW] " CtrlC-Root
2023-07-11 15:56 ` CtrlC-Root
2023-07-11 15:56 ` CtrlC-Root
2023-07-11 15:58 ` CtrlC-Root [this message]
2023-07-11 16:16 ` Duncaen
2023-07-11 16:16 ` Duncaen
2023-07-11 16:19 ` CtrlC-Root
2023-07-11 16:26 ` [PR PATCH] [Updated] " CtrlC-Root
2023-07-11 16:27 ` [PR REVIEW] " CtrlC-Root
2023-07-15 5:56 ` [PR PATCH] [Merged]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230711155855.zb-3pje--m63UUCwaWFfoqtUFvZQ5tKe8Rj8qJwnfJ8@z \
--to=ctrlc-root@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).