[PR PATCH] New package: spacenavd-1.2-1

[PR PATCH] New package: spacenavd-1.2-1

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 763 bytes --]

There is a new pull request by CtrlC-Root against master on the void-packages repository

https://github.com/CtrlC-Root/void-packages spacenavd
https://github.com/void-linux/void-packages/pull/44959

New package: spacenavd-1.2-1
#### Testing the changes
- I tested the changes in this PR: **YES**

With the following:

* libspnav-1.1_1
* freecad-0.20.2_5
* 3DConnexion SpaceMouse Pro Wireless

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/44959.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-spacenavd-44959.patch --]
[-- Type: text/x-diff, Size: 1569 bytes --]

From 6eb525ba72d16c5362122027445447a8c2982e1f Mon Sep 17 00:00:00 2001
From: Alexandru Barbur <alex@ctrlc.name>
Date: Sun, 9 Jul 2023 21:19:06 -0400
Subject: [PATCH] New package: spacenavd-1.2-1

---
 srcpkgs/spacenavd/files/run |  3 +++
 srcpkgs/spacenavd/template  | 20 ++++++++++++++++++++
 2 files changed, 23 insertions(+)
 create mode 100644 srcpkgs/spacenavd/files/run
 create mode 100644 srcpkgs/spacenavd/template

diff --git a/srcpkgs/spacenavd/files/run b/srcpkgs/spacenavd/files/run
new file mode 100644
index 000000000000..f8155df24500
--- /dev/null
+++ b/srcpkgs/spacenavd/files/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+
+exec spacenavd -d
diff --git a/srcpkgs/spacenavd/template b/srcpkgs/spacenavd/template
new file mode 100644
index 000000000000..6c4b91e428ec
--- /dev/null
+++ b/srcpkgs/spacenavd/template
@@ -0,0 +1,20 @@
+# Template file for 'spacenavd'
+pkgname=spacenavd
+version=1.2
+revision=1
+build_style=gnu-configure
+makedepends="libspnav-devel libX11-devel libXtst-devel"
+depends="libspnav"
+short_desc="Userspace driver for 6-dof input devices"
+maintainer="Alexandru Barbur <alex@ctrlc.name>"
+license="GPL-3.0-or-later"
+homepage="http://spacenav.sourceforge.net"
+changelog="https://github.com/FreeSpacenav/spacenavd/releases"
+distfiles="https://github.com/FreeSpacenav/spacenavd/archive/refs/tags/v${version}.tar.gz"
+checksum="4b4096908f842f697a6410a5a873ff4927bd24bd041b6d60b111e90da1178840"
+conf_files="/etc/spnavrc"
+
+post_install() {
+	vinstall ${FILESDIR}/run 755 etc/sv/spacenavd/
+	vinstall doc/example-spnavrc 644 etc/ spnavrc
+}

Re: [PR REVIEW] New package: spacenavd-1.2-1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/44959#discussion_r1258666720

Comment:
```suggestion
exec 2>&1
```

Re: [PR REVIEW] New package: spacenavd-1.2-1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/44959#discussion_r1258666971

Comment:
use vsv

Re: [PR REVIEW] New package: spacenavd-1.2-1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/44959#discussion_r1258668210

Comment:
use vconf

Re: [PR REVIEW] New package: spacenavd-1.2-1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/44959#discussion_r1258667291

Comment:
probably autodetected

Re: [PR PATCH] [Updated] New package: spacenavd-1.2-1

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]

There is an updated pull request by CtrlC-Root against master on the void-packages repository

https://github.com/CtrlC-Root/void-packages spacenavd
https://github.com/void-linux/void-packages/pull/44959

New package: spacenavd-1.2-1
#### Testing the changes
- I tested the changes in this PR: **YES**

With the following:

* libspnav-1.1_1
* freecad-0.20.2_5
* 3DConnexion SpaceMouse Pro Wireless

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/44959.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-spacenavd-44959.patch --]
[-- Type: text/x-diff, Size: 1596 bytes --]

From 9cc48924ccc11c7e2ac591643aeaddce28230987 Mon Sep 17 00:00:00 2001
From: Alexandru Barbur <alex@ctrlc.name>
Date: Sun, 9 Jul 2023 21:19:06 -0400
Subject: [PATCH] New package: spacenavd-1.2-1

---
 srcpkgs/spacenavd/files/spacenavd/run |  4 ++++
 srcpkgs/spacenavd/template            | 20 ++++++++++++++++++++
 2 files changed, 24 insertions(+)
 create mode 100644 srcpkgs/spacenavd/files/spacenavd/run
 create mode 100644 srcpkgs/spacenavd/template

diff --git a/srcpkgs/spacenavd/files/spacenavd/run b/srcpkgs/spacenavd/files/spacenavd/run
new file mode 100644
index 000000000000..711ead4ab2fc
--- /dev/null
+++ b/srcpkgs/spacenavd/files/spacenavd/run
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+exec 2>&1
+exec spacenavd -d
diff --git a/srcpkgs/spacenavd/template b/srcpkgs/spacenavd/template
new file mode 100644
index 000000000000..528ab080d97e
--- /dev/null
+++ b/srcpkgs/spacenavd/template
@@ -0,0 +1,20 @@
+# Template file for 'spacenavd'
+pkgname=spacenavd
+version=1.2
+revision=1
+build_style=gnu-configure
+makedepends="libspnav-devel libX11-devel libXtst-devel"
+depends="libspnav"
+short_desc="Userspace driver for 6-dof input devices"
+maintainer="Alexandru Barbur <alex@ctrlc.name>"
+license="GPL-3.0-or-later"
+homepage="http://spacenav.sourceforge.net"
+changelog="https://github.com/FreeSpacenav/spacenavd/releases"
+distfiles="https://github.com/FreeSpacenav/spacenavd/archive/refs/tags/v${version}.tar.gz"
+checksum="4b4096908f842f697a6410a5a873ff4927bd24bd041b6d60b111e90da1178840"
+conf_files="/etc/spnavrc"
+
+post_install() {
+	vconf doc/example-spnavrc spnavrc
+	vsv spacenavd
+}

Re: [PR REVIEW] New package: spacenavd-1.2-1

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

New review comment by CtrlC-Root on void-packages repository

https://github.com/void-linux/void-packages/pull/44959#discussion_r1259945523

Comment:
Fixed in https://github.com/void-linux/void-packages/commit/9cc48924ccc11c7e2ac591643aeaddce28230987

Re: [PR REVIEW] New package: spacenavd-1.2-1

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

New review comment by CtrlC-Root on void-packages repository

https://github.com/void-linux/void-packages/pull/44959#discussion_r1259945708

Comment:
Fixed in https://github.com/void-linux/void-packages/commit/9cc48924ccc11c7e2ac591643aeaddce28230987

Re: [PR REVIEW] New package: spacenavd-1.2-1

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

New review comment by CtrlC-Root on void-packages repository

https://github.com/void-linux/void-packages/pull/44959#discussion_r1259945905

Comment:
Fixed in https://github.com/void-linux/void-packages/commit/9cc48924ccc11c7e2ac591643aeaddce28230987

Re: [PR REVIEW] New package: spacenavd-1.2-1

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 741 bytes --]

New review comment by CtrlC-Root on void-packages repository

https://github.com/void-linux/void-packages/pull/44959#discussion_r1259948835

Comment:
I spent some time digging into the XBPS scripts that do this. Yeah it does seem like it would likely detect this dependency correctly. Do you have any thoughts or preferences on whether any automatically detected dependencies should still be listed here? Should I always omit ones that can be autodetected? I'm asking because you left similar feedback on a different PR (for spnavcfg) so I want to learn the rule and apply it everywhere going forward. I'm tempted to put dependencies that I know up front into this variable as a form of documentation but I'll do whatever you think is best.

Re: [PR REVIEW] New package: spacenavd-1.2-1

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/44959#discussion_r1259968883

Comment:
They should be omitted, the automatically added ones are more precise and generate dependencies based on the minimum version required to provide a specific shared library version.

Re: [PR REVIEW] New package: spacenavd-1.2-1

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 328 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/44959#discussion_r1259968883

Comment:
They should be omitted, the automatically added ones are more precise by generating dependencies based on the minimum version required to provide a specific shared library version.

Re: [PR REVIEW] New package: spacenavd-1.2-1

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

New review comment by CtrlC-Root on void-packages repository

https://github.com/void-linux/void-packages/pull/44959#discussion_r1259972232

Comment:
Ok, will do.

Re: [PR PATCH] [Updated] New package: spacenavd-1.2-1

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]

There is an updated pull request by CtrlC-Root against master on the void-packages repository

https://github.com/CtrlC-Root/void-packages spacenavd
https://github.com/void-linux/void-packages/pull/44959

New package: spacenavd-1.2-1
#### Testing the changes
- I tested the changes in this PR: **YES**

With the following:

* libspnav-1.1_1
* freecad-0.20.2_5
* 3DConnexion SpaceMouse Pro Wireless

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/44959.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-spacenavd-44959.patch --]
[-- Type: text/x-diff, Size: 1560 bytes --]

From 638c0aa1b2b66e3ccfeb6984b7cd344512a4965a Mon Sep 17 00:00:00 2001
From: Alexandru Barbur <alex@ctrlc.name>
Date: Sun, 9 Jul 2023 21:19:06 -0400
Subject: [PATCH] New package: spacenavd-1.2-1

---
 srcpkgs/spacenavd/files/spacenavd/run |  4 ++++
 srcpkgs/spacenavd/template            | 19 +++++++++++++++++++
 2 files changed, 23 insertions(+)
 create mode 100644 srcpkgs/spacenavd/files/spacenavd/run
 create mode 100644 srcpkgs/spacenavd/template

diff --git a/srcpkgs/spacenavd/files/spacenavd/run b/srcpkgs/spacenavd/files/spacenavd/run
new file mode 100644
index 000000000000..711ead4ab2fc
--- /dev/null
+++ b/srcpkgs/spacenavd/files/spacenavd/run
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+exec 2>&1
+exec spacenavd -d
diff --git a/srcpkgs/spacenavd/template b/srcpkgs/spacenavd/template
new file mode 100644
index 000000000000..bc19b380ab6f
--- /dev/null
+++ b/srcpkgs/spacenavd/template
@@ -0,0 +1,19 @@
+# Template file for 'spacenavd'
+pkgname=spacenavd
+version=1.2
+revision=1
+build_style=gnu-configure
+makedepends="libX11-devel libXtst-devel"
+short_desc="Userspace driver for 6-dof input devices"
+maintainer="Alexandru Barbur <alex@ctrlc.name>"
+license="GPL-3.0-or-later"
+homepage="http://spacenav.sourceforge.net"
+changelog="https://github.com/FreeSpacenav/spacenavd/releases"
+distfiles="https://github.com/FreeSpacenav/spacenavd/archive/refs/tags/v${version}.tar.gz"
+checksum="4b4096908f842f697a6410a5a873ff4927bd24bd041b6d60b111e90da1178840"
+conf_files="/etc/spnavrc"
+
+post_install() {
+	vconf doc/example-spnavrc spnavrc
+	vsv spacenavd
+}

Re: [PR REVIEW] New package: spacenavd-1.2-1

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

New review comment by CtrlC-Root on void-packages repository

https://github.com/void-linux/void-packages/pull/44959#discussion_r1259981758

Comment:
Surprisingly it doesn't even depend on `libspnav` at all! The important protocol bits are copy and pasted between the two. Fixed in https://github.com/void-linux/void-packages/commit/638c0aa1b2b66e3ccfeb6984b7cd344512a4965a.

Re: [PR PATCH] [Merged]: New package: spacenavd-1.2-1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

There's a merged pull request on the void-packages repository

New package: spacenavd-1.2-1
https://github.com/void-linux/void-packages/pull/44959

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

With the following:

* libspnav-1.1_1
* freecad-0.20.2_5
* 3DConnexion SpaceMouse Pro Wireless

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64