From: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Closed]: set null IFS in v* commands
Date: Wed, 12 Jul 2023 04:06:39 +0200 [thread overview]
Message-ID: <20230712020639.333CNaueFLLDzqKqrP2rpsldwGv8O69dtpFlhAk2zD0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42850@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 896 bytes --]
There's a closed pull request on the void-packages repository
set null IFS in v* commands
https://github.com/void-linux/void-packages/pull/42850
Description:
without this, if `<pattern>` arguments contain whitespace, word splitting causes the argument to be split unexpectedly.
for example:
`vcopy 'Spacey Folder/*.ttf' usr/share/TTF/`
calls something equivalent to
`cp "Spacey" "Folder/*.ttf" usr/share/TTF/`
which of course fails.
i couldn't find a way to escape word splitting from outside, aside from setting `IFS`.
i'm not at all confident this won't break anything else in install.sh, but if it doesn't, i think it would be nice to preserve the expectation that `<pattern>` arguments are just pure globs.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
prev parent reply other threads:[~2023-07-12 2:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-18 22:30 [PR PATCH] " gandalf3
2023-03-18 22:54 ` paper42
2023-03-20 4:42 ` classabbyamp
2023-03-28 15:21 ` Chocimier
2023-03-28 15:25 ` classabbyamp
2023-03-28 19:25 ` Chocimier
2023-06-27 2:08 ` github-actions
2023-07-12 2:06 ` github-actions [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230712020639.333CNaueFLLDzqKqrP2rpsldwGv8O69dtpFlhAk2zD0@z \
--to=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).