From: Duncaen <Duncaen@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: lemoa-0.2.0
Date: Wed, 12 Jul 2023 16:21:36 +0200 [thread overview]
Message-ID: <20230712142136.JYWpLfE8ueYM5XV7hzbA8IleSsGh99UwLZzOo8qmFF4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-44687@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 386 bytes --]
New review comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/44687#discussion_r1261256839
Comment:
This should probably be `post_patch` or `post_extract`, meson will reconfigure the build if you change the meson.build file. I guess meson is smart enough to reuse the previous configuration, but its cleaner to patch prior to configuring.
next prev parent reply other threads:[~2023-07-12 14:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 17:54 [PR PATCH] New package: lemoa-0.1.0 Bnyro
2023-06-30 15:26 ` [PR PATCH] [Updated] " Bnyro
2023-06-30 15:27 ` Bnyro
2023-07-12 13:50 ` [PR PATCH] [Merged]: New package: lemoa-0.2.0 Duncaen
2023-07-12 14:18 ` Bnyro
2023-07-12 14:21 ` Duncaen [this message]
2023-07-12 14:26 ` [PR REVIEW] " Bnyro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230712142136.JYWpLfE8ueYM5XV7hzbA8IleSsGh99UwLZzOo8qmFF4@z \
--to=duncaen@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).