From: atk <atk@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] vscode: update to 1.80.0
Date: Fri, 14 Jul 2023 10:10:44 +0200 [thread overview]
Message-ID: <20230714081044.PfQAUR98qsyCDDOtgZrDtp1knSff_tEsiOVOTBd4IUc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-45012@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1373 bytes --]
There is an updated pull request by atk against master on the void-packages repository
https://github.com/atk/void-packages vscode-1.80.0
https://github.com/void-linux/void-packages/pull/45012
vscode: update to 1.80.0
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
The new version tests the checksum of the electron package; since we are using our own build of electron, we need to disable this check.
A patch file from https://github.com/void-linux/void-packages/pull/45012.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vscode-1.80.0-45012.patch --]
[-- Type: text/x-diff, Size: 1583 bytes --]
From 68c48f2346295af49633f8012a1fac3efcd4aa33 Mon Sep 17 00:00:00 2001
From: Alex Lohr <alex.lohr@logmein.com>
Date: Fri, 14 Jul 2023 10:10:31 +0200
Subject: [PATCH] vscode: update to 1.80.0
---
srcpkgs/vscode/template | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/vscode/template b/srcpkgs/vscode/template
index a7d418f5696f..98f9c274090f 100644
--- a/srcpkgs/vscode/template
+++ b/srcpkgs/vscode/template
@@ -1,8 +1,8 @@
# Template file for 'vscode'
pkgname=vscode
-version=1.79.2
+version=1.80.0
revision=1
-_electronver=24.2.0
+_electronver=24.3.0
_npmver=8.6.0
hostmakedepends="pkg-config python3 nodejs yarn tar git ripgrep"
makedepends="libxkbfile-devel libsecret-devel libxml2-devel ncurses-devel electron24"
@@ -12,7 +12,7 @@ maintainer="shizonic <realtiaz@gmail.com>, Alex Lohr <alex.lohr@logmein.com>"
license="MIT"
homepage="https://code.visualstudio.com/"
distfiles="https://github.com/microsoft/vscode/archive/refs/tags/${version}.tar.gz"
-checksum=2719ccbb573f5b7c174bd5bbcad97d3fe4d917e16327a6b72162ff7014c17c9b
+checksum=92145abba63cd0e36876bf4c1f79ee208dca5bd272ecc31e976028feaea97c73
nocross=yes # x64 build does not cut it, it contains native code
if [ "$XBPS_TARGET_WORDSIZE" = "32" ]; then
@@ -67,6 +67,9 @@ do_build() {
yarn install --frozen-lockfile --arch=x64
+ # do not checksum electron, since we're using our own build
+ vsed -e "s/validateChecksum: true/validateChecksum: false/g" -i build/lib/electron.*s
+
export CFLAGS="$CFLAGS -I/usr/include/node"
yarn run gulp vscode-linux-x64-min
}
next prev parent reply other threads:[~2023-07-14 8:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 10:11 [PR PATCH] " atk
2023-07-14 8:10 ` atk [this message]
2023-07-14 11:31 ` [PR PATCH] [Updated] " atk
2023-07-19 11:50 ` [PR PATCH] [Updated] vscode: update to 1.80.1 atk
2023-07-19 22:28 ` [PR PATCH] [Merged]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230714081044.PfQAUR98qsyCDDOtgZrDtp1knSff_tEsiOVOTBd4IUc@z \
--to=atk@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).