Github messages for voidlinux
 help / color / mirror / Atom feed
From: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Closed]: update-check: no partial response and not trust insecure certificate
Date: Sun, 16 Jul 2023 04:13:18 +0200	[thread overview]
Message-ID: <20230716021318.KaQcb_RVetHBwEcex5PrQlb7HB-l51o4sbwVN7H9jSI@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43192@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1664 bytes --]

There's a closed pull request on the void-packages repository

update-check: no partial response and not trust insecure certificate
https://github.com/void-linux/void-packages/pull/43192

Description:
1. My network is slow, `./xbps-src update-check xorg-server` takes 50s and `./xbps-src update-check xorg-server-xwayland` takes 11s, `curl --max-time 10` returns partial response but no error.  So I remove `--max-time 10` and add `-f` to forbid partial response. It's better to call `set -eo pipefail` for the whole script but I'm not sure whether it will break the script.  The CI job or interactive execution can have their own timeout.

2. `-k` means `--insecure`, it's bad, we should always validate HTTPS server certificate.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


      parent reply	other threads:[~2023-07-16  2:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-02 10:50 [PR PATCH] " Dieken
2023-04-02 20:27 ` classabbyamp
2023-04-02 23:07 ` Dieken
2023-04-02 23:15 ` classabbyamp
2023-04-02 23:16 ` classabbyamp
2023-04-02 23:28 ` Dieken
2023-04-02 23:43 ` Duncaen
2023-04-02 23:43 ` classabbyamp
2023-04-02 23:56 ` Duncaen
2023-04-03  0:02 ` Duncaen
2023-04-03  0:13 ` Dieken
2023-04-03  0:17 ` Dieken
2023-07-02  2:10 ` github-actions
2023-07-16  2:13 ` github-actions [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230716021318.KaQcb_RVetHBwEcex5PrQlb7HB-l51o4sbwVN7H9jSI@z \
    --to=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).