From: xaizek <xaizek@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] vifm: update to 0.13
Date: Mon, 24 Jul 2023 19:02:22 +0200 [thread overview]
Message-ID: <20230724170222.DU1KPKfDu-w83-ayn5T3ww3ZFqbEUxd9g0NZucvJMJY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-44870@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 609 bytes --]
New review comment by xaizek on void-packages repository
https://github.com/void-linux/void-packages/pull/44870#discussion_r1272526180
Comment:
A fix could look like adding this at the top of `src/sort.c` (before or after includes, doesn't really matter):
```c
#ifdef HAVE_STRVERSCMP_FUNC
# undef HAVE_STRVERSCMP_FUNC
#endif
```
(`#undef` alone might also work, but just in case.)
This will always use custom implementation of `strverscmp()` (Windows doesn't have it and BSD-systems probably too). The tests validate custom implementation and that behaviour is consistent across various systems.
next prev parent reply other threads:[~2023-07-24 17:02 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 22:33 [PR PATCH] Update vifm " hholst80
2023-07-05 22:35 ` hholst80
2023-07-05 22:39 ` [PR PATCH] [Updated] " hholst80
2023-07-05 22:42 ` [PR REVIEW] " classabbyamp
2023-07-05 23:06 ` [PR PATCH] [Updated] " hholst80
2023-07-05 23:14 ` hholst80
2023-07-05 23:28 ` hholst80
2023-07-05 23:30 ` hholst80
2023-07-05 23:45 ` [PR REVIEW] " classabbyamp
2023-07-06 12:29 ` [PR PATCH] [Updated] " hholst80
2023-07-06 22:07 ` vifm: update " hholst80
2023-07-08 16:05 ` [PR PATCH] [Updated] " hholst80
2023-07-08 16:28 ` hholst80
2023-07-13 14:25 ` [PR PATCH] [Updated] " hholst80
2023-07-13 14:28 ` hholst80
2023-07-24 13:16 ` hholst80
2023-07-24 13:37 ` [PR REVIEW] " classabbyamp
2023-07-24 13:37 ` classabbyamp
2023-07-24 13:37 ` classabbyamp
2023-07-24 15:07 ` hholst80
2023-07-24 15:17 ` hholst80
2023-07-24 15:26 ` hholst80
2023-07-24 15:26 ` [PR PATCH] [Updated] " hholst80
2023-07-24 15:29 ` [PR REVIEW] " xaizek
2023-07-24 15:30 ` classabbyamp
2023-07-24 16:13 ` ahesford
2023-07-24 17:01 ` xaizek
2023-07-24 17:02 ` xaizek [this message]
2023-07-24 19:43 ` hholst80
2023-07-24 20:24 ` ahesford
2023-07-24 20:24 ` [PR PATCH] [Closed]: " ahesford
2023-07-24 21:39 ` hholst80
2023-07-24 21:42 ` ahesford
2023-07-24 22:02 ` xaizek
2023-07-24 22:02 ` hholst80
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230724170222.DU1KPKfDu-w83-ayn5T3ww3ZFqbEUxd9g0NZucvJMJY@z \
--to=xaizek@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).