From: Chocimier <Chocimier@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: xbps-src: new vopt_feature helper
Date: Wed, 26 Jul 2023 20:31:49 +0200 [thread overview]
Message-ID: <20230726183149.qASakIzW5cw-tsRLKJFIbSCnURdYALj4ChGlJ2dISlc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-44663@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 769 bytes --]
There's a merged pull request on the void-packages repository
xbps-src: new vopt_feature helper
https://github.com/void-linux/void-packages/pull/44663
Description:
#### Testing the changes
- I tested the changes in this PR: **briefly**
I didn't check this against every template where the pattern appears, but it works in the test cases I tried.
---
This helper function reduces boilerplate for [Meson's "feature" build options](https://mesonbuild.com/Build-options.html#features). Right now these are handled using the pattern `-D<property>=$(vopt_if <option> enabled disabled)`, which occurs 78 times in our templates.
Note that this does *not* allow you to set the property to "auto", but I can't think of any situation where that would be desirable.
next prev parent reply other threads:[~2023-07-26 18:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 16:07 [PR PATCH] xbps-src: new vopt_feat helper cinerea0
2023-07-01 21:57 ` Chocimier
2023-07-02 18:17 ` eli-schwartz
2023-07-04 2:30 ` [PR PATCH] [Updated] " cinerea0
2023-07-04 2:31 ` cinerea0
2023-07-04 2:40 ` eli-schwartz
2023-07-04 2:40 ` eli-schwartz
2023-07-26 18:31 ` Chocimier [this message]
2023-07-26 18:32 ` xbps-src: new vopt_feature helper Chocimier
2023-07-26 20:38 ` cinerea0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230726183149.qASakIzW5cw-tsRLKJFIbSCnURdYALj4ChGlJ2dISlc@z \
--to=chocimier@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).