From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: knot-resolver: config fixes + add garbage collector service
Date: Fri, 28 Jul 2023 06:42:08 +0200 [thread overview]
Message-ID: <20230728044208.6aCWOLGbodZ0zni3KlrqERclOhkmaWExyCls7J3Gs4A@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-45209@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]
There's a merged pull request on the void-packages repository
knot-resolver: config fixes + add garbage collector service
https://github.com/void-linux/void-packages/pull/45209
Description:
#### Testing the changes
- I tested the changes in this PR: **YES**
## First
In the default installation the default config file (/etc/knot-resolver/kresd.conf) is not read: so making changes to it, did nothing.
Per https://github.com/void-linux/void-packages/blob/master/Manual.md#writing_runit_services
you _could_ change CLI flags in **conf** file in the service directory, but I think this option should be enabled by default because the file /etc/knot-resolver/kresd.conf is also installed and otherwise it's confusing.
## Second
Added working directory to kresd service file, otherwise it uses the service directory itself.
## Third
change: in default CLI variable:
```
-f 1
```
to
```
--noninteractive
```
because _-f 1_ will be deprecated per warning on command line.
## Fourth
knot-resolver comes with a garbage collector (kres-cache-gc).
I added a service file for it.
prev parent reply other threads:[~2023-07-28 4:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-23 19:37 [PR PATCH] knot-resolver: fix configfile location in runit service MeganerdNL
2023-07-23 19:42 ` classabbyamp
2023-07-23 21:00 ` MeganerdNL
2023-07-23 21:07 ` [PR PATCH] [Updated] " MeganerdNL
2023-07-23 21:08 ` MeganerdNL
2023-07-23 21:09 ` MeganerdNL
2023-07-23 21:10 ` MeganerdNL
2023-07-23 21:10 ` MeganerdNL
2023-07-24 14:09 ` MeganerdNL
2023-07-25 6:19 ` [PR PATCH] [Updated] " MeganerdNL
2023-07-25 6:22 ` MeganerdNL
2023-07-25 6:30 ` classabbyamp
2023-07-25 7:08 ` [PR PATCH] [Updated] " MeganerdNL
2023-07-25 7:08 ` MeganerdNL
2023-07-25 7:08 ` MeganerdNL
2023-07-25 20:48 ` [PR PATCH] [Updated] " MeganerdNL
2023-07-25 20:50 ` MeganerdNL
2023-07-25 20:50 ` MeganerdNL
2023-07-25 20:55 ` MeganerdNL
2023-07-25 21:08 ` [PR PATCH] [Updated] knot-resolver: config fixes + add garbage collector service MeganerdNL
2023-07-25 21:14 ` Duncaen
2023-07-26 1:28 ` classabbyamp
2023-07-26 5:22 ` [PR PATCH] [Updated] " MeganerdNL
2023-07-26 5:25 ` MeganerdNL
2023-07-26 5:30 ` MeganerdNL
2023-07-28 4:42 ` classabbyamp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230728044208.6aCWOLGbodZ0zni3KlrqERclOhkmaWExyCls7J3Gs4A@z \
--to=classabbyamp@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).