[PR PATCH] [RFC] CONTRIBUTING.md: describe adoption/orphaning policy and procedure

[PR PATCH] [RFC] CONTRIBUTING.md: describe adoption/orphaning policy and procedure

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

There is a new pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages contrib-adopt
https://github.com/void-linux/void-packages/pull/45207

[RFC] CONTRIBUTING.md: describe adoption/orphaning policy and procedure
I think it would be good to codify some of this. Open to suggestions on everything.

@void-linux/pkg-committers 

A patch file from https://github.com/void-linux/void-packages/pull/45207.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-contrib-adopt-45207.patch --]
[-- Type: text/x-diff, Size: 1798 bytes --]

From 9332ffcddd8270bf51f2681360860ebdf9cfe7d0 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Sun, 23 Jul 2023 11:03:01 -0400
Subject: [PATCH] CONTRIBUTING.md: describe adoption/orphaning policy and
 procedure

---
 CONTRIBUTING.md | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index a8f58bbb37445..52ca1b18b48ff 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -82,6 +82,25 @@ The checksum can be updated automatically with the `xgensum` helper from the [xt
 
     $ xgensum -i <pkgname>
 
+### Adopting a template
+
+If a template is orphaned (maintained by `orphan@voidlinux.org`) or the current `maintainer` has not contributed in a long
+time (over a year), template maintainership can be adopted by someone else. To ensure a template gets the care it needs,
+template adopters should use the package in question and have a history of contributing changes to that template (updating
+the template several times, for example).
+
+It is best to adopt a template when making another change to it. When adopting the template, add your name or username
+and email to the `maintainer` field in the template, and mention the adoption in your commit message, for example:
+
+    libfoo: update to 1.2.3, adopt.
+
+### Orphaning a template
+
+If you no longer wish to maintain a template, you can remove yourself as maintainer by setting the `maintainer` field in
+the template to `Orphaned <orphan@voidlinux.org>`. The commit message should mention this, for example:
+
+    libfoo: update to 1.2.3, orphan.
+
 ### Committing your changes
 
 After making your changes, please check that the package builds successfully. From the top level directory of your local copy of the `void-packages` repository, run:

Re: [PR REVIEW] [RFC] CONTRIBUTING.md: describe adoption/orphaning policy and procedure

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/45207#discussion_r1271466743

Comment:
Might also want to mention that a package can be orphaned without having to make another change to the template?

Re: [RFC] CONTRIBUTING.md: describe adoption/orphaning policy and procedure

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/45207#issuecomment-1646885481

Comment:
`package` instead of `template` sounds more natural to me.

Re: [RFC] CONTRIBUTING.md: describe adoption/orphaning policy and procedure

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/45207#issuecomment-1646888584

Comment:
template is used throughout most of the rest of the document 

Re: [PR REVIEW] [RFC] CONTRIBUTING.md: describe adoption/orphaning policy and procedure

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New review comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/45207#discussion_r1271669930

Comment:
And whether a rebuild is needed or wanted in that case.

Re: [PR REVIEW] [RFC] CONTRIBUTING.md: describe adoption/orphaning policy and procedure

[0x5c]

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

New review comment by 0x5c on void-packages repository

https://github.com/void-linux/void-packages/pull/45207#discussion_r1272035950

Comment:
The requirement of having contributed to a specific template multiple times might lock many packages in permanent maintainerless limbo, like those that very rarely get releases.

Might be best to not require more than usage of the template + an history of contribution to any packages, and recommend not adopting without doing another change like the next paragraph does.

Re: [PR REVIEW] [RFC] CONTRIBUTING.md: describe adoption/orphaning policy and procedure

[0x5c]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

New review comment by 0x5c on void-packages repository

https://github.com/void-linux/void-packages/pull/45207#discussion_r1272028737

Comment:
`contributed [to any packages]` ?
A template might look abandoned if the packages has not got a release in a long time

Re: [PR REVIEW] [RFC] CONTRIBUTING.md: describe adoption/orphaning policy and procedure

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 664 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/45207#discussion_r1272320396

Comment:
```suggestion
If a template is orphaned (maintained by `orphan@voidlinux.org`) or the current `maintainer` has not made contributions to Void in at least a year, template maintainership can be adopted by someone else. To ensure a template gets the care it needs, users wishing to adopt a template should be familiar with the package and have an established history of contributions to Void. Those who have contributed several updates, especially for the template in question, are good candidates for adoption.
```

Re: [PR REVIEW] [RFC] CONTRIBUTING.md: describe adoption/orphaning policy and procedure

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/45207#discussion_r1272367559

Comment:
My take:
```suggestion
If a template is orphaned (maintained by `orphan@voidlinux.org`) or the current maintainer has not made contributions to Void in at least a year, the template can be orphaned or adopted by someone else. To ensure a template gets the care it needs, users wishing to adopt a template should be familiar with the package and have an established history of contributions to Void. Those who have contributed several updates, especially to the template in question, are good candidates for adoption.
```

Re: [PR REVIEW] [RFC] CONTRIBUTING.md: describe adoption/orphaning policy and procedure

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

New review comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/45207#discussion_r1272479467

Comment:
"Those who have contributed several updates [...] are good candidates for adoption"

Sounds like the maintainers are the ones being adopted.

Re: [RFC] CONTRIBUTING.md: describe adoption/orphaning policy and procedure

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 387 bytes --]

New comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/45207#issuecomment-1648678336

Comment:
Please remember all we are not codifying package adoption and orphaning in code. We're trying to codify the process in a little way so we don't see people adopt a package in their first ever contribution, taking over from an active maintainer.

Re: [PR PATCH] [Updated] [RFC] CONTRIBUTING.md: describe adoption/orphaning policy and procedure

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]

There is an updated pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages contrib-adopt
https://github.com/void-linux/void-packages/pull/45207

[RFC] CONTRIBUTING.md: describe adoption/orphaning policy and procedure
I think it would be good to codify some of this. Open to suggestions on everything.

@void-linux/pkg-committers 

A patch file from https://github.com/void-linux/void-packages/pull/45207.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-contrib-adopt-45207.patch --]
[-- Type: text/x-diff, Size: 2033 bytes --]

From f4bf28773fede663cf93d98c49c5fda3b365c0de Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Sun, 23 Jul 2023 11:03:01 -0400
Subject: [PATCH] CONTRIBUTING.md: describe adoption/orphaning policy and
 procedure

---
 CONTRIBUTING.md | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index a8f58bbb37445..4cbb475eaa9cf 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -82,6 +82,29 @@ The checksum can be updated automatically with the `xgensum` helper from the [xt
 
     $ xgensum -i <pkgname>
 
+### Adopting a template
+
+If a template is orphaned (maintained by `orphan@voidlinux.org`) or the current `maintainer` has not contributed to
+void-packages in a long time (over a year), template maintainership can be adopted by someone else. To ensure a template
+gets the care it needs, template adopters should be familiar with the package and have an established history of
+contributions to Void. Those who have contributed several updates, especially for the template in question, are good
+candidates for template maintainership.
+
+It is best to adopt a template when making another change to it. When adopting the template, add your name or username
+and email to the `maintainer` field in the template, and mention the adoption in your commit message, for example:
+
+    libfoo: update to 1.2.3, adopt.
+
+### Orphaning a template
+
+If you no longer wish to maintain a template, you can remove yourself as maintainer by setting the `maintainer` field in
+the template to `Orphaned <orphan@voidlinux.org>`. The commit message should mention this, for example:
+
+    libfoo: orphan.
+
+It is not necessary to make other changes to the template when orphaning, and incrementing the revision (triggering a
+rebuild) is not necessary.
+
 ### Committing your changes
 
 After making your changes, please check that the package builds successfully. From the top level directory of your local copy of the `void-packages` repository, run:

Re: [RFC] CONTRIBUTING.md: describe adoption/orphaning policy and procedure

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/45207#issuecomment-1654987320

Comment:
feedback incorporated

Re: [PR PATCH] [Updated] [RFC] CONTRIBUTING.md: describe adoption/orphaning policy and procedure

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]

There is an updated pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages contrib-adopt
https://github.com/void-linux/void-packages/pull/45207

[RFC] CONTRIBUTING.md: describe adoption/orphaning policy and procedure
I think it would be good to codify some of this. Open to suggestions on everything.

@void-linux/pkg-committers 

A patch file from https://github.com/void-linux/void-packages/pull/45207.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-contrib-adopt-45207.patch --]
[-- Type: text/x-diff, Size: 2010 bytes --]

From 3cefb41109c8f6b217c15f7a6c7c6d35cb2ef931 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Sun, 23 Jul 2023 11:03:01 -0400
Subject: [PATCH] CONTRIBUTING.md: describe adoption/orphaning policy and
 procedure

---
 CONTRIBUTING.md | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index a8f58bbb37445..166b6c3fa1bf2 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -82,6 +82,29 @@ The checksum can be updated automatically with the `xgensum` helper from the [xt
 
     $ xgensum -i <pkgname>
 
+### Adopting a template
+
+If a template is orphaned (maintained by `orphan@voidlinux.org`) or the current `maintainer` has not contributed to
+Void in over a year, template maintainership can be adopted by someone else. To ensure a template gets the care it needs,
+template adopters should be familiar with the package and have an established history of contributions to Void.
+Those who have contributed several updates, especially for the template in question, are good candidates for template
+maintainership.
+
+It is best to adopt a template when making another change to it. When adopting the template, add your name or username
+and email to the `maintainer` field in the template, and mention the adoption in your commit message, for example:
+
+    libfoo: update to 1.2.3, adopt.
+
+### Orphaning a template
+
+If you no longer wish to maintain a template, you can remove yourself as maintainer by setting the `maintainer` field in
+the template to `Orphaned <orphan@voidlinux.org>`. The commit message should mention this, for example:
+
+    libfoo: orphan.
+
+It is not necessary to make other changes to the template when orphaning, and incrementing the revision (triggering a
+rebuild) is not necessary.
+
 ### Committing your changes
 
 After making your changes, please check that the package builds successfully. From the top level directory of your local copy of the `void-packages` repository, run:

Re: [PR REVIEW] [RFC] CONTRIBUTING.md: describe adoption/orphaning policy and procedure

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 282 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/45207#discussion_r1277355973

Comment:
```suggestion
If a template is orphaned (maintained by `orphan@voidlinux.org`) or the current maintainer has not contributed to
```

Re: [PR REVIEW] [RFC] CONTRIBUTING.md: describe adoption/orphaning policy and procedure

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/45207#discussion_r1278120309

Comment:
I code-quoted it to indicate that it's the variable in the template

Re: [PR REVIEW] [RFC] CONTRIBUTING.md: describe adoption/orphaning policy and procedure

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/45207#discussion_r1278281326

Comment:
Fine then.

Re: [PR REVIEW] [RFC] CONTRIBUTING.md: describe adoption/orphaning policy and procedure

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/45207#discussion_r1278281394

Comment:
```suggestion
rebuild) is not necessary either.
```

After this it's good to go for me.

Re: [PR PATCH] [Updated] [RFC] CONTRIBUTING.md: describe adoption/orphaning policy and procedure

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]

There is an updated pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages contrib-adopt
https://github.com/void-linux/void-packages/pull/45207

[RFC] CONTRIBUTING.md: describe adoption/orphaning policy and procedure
I think it would be good to codify some of this. Open to suggestions on everything.

@void-linux/pkg-committers 

A patch file from https://github.com/void-linux/void-packages/pull/45207.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-contrib-adopt-45207.patch --]
[-- Type: text/x-diff, Size: 2017 bytes --]

From 5652d299a13a0de48fdea3e02e480ffd8e73e4a0 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Sun, 23 Jul 2023 11:03:01 -0400
Subject: [PATCH] CONTRIBUTING.md: describe adoption/orphaning policy and
 procedure

---
 CONTRIBUTING.md | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index a8f58bbb37445..471b0ed2ddc88 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -82,6 +82,29 @@ The checksum can be updated automatically with the `xgensum` helper from the [xt
 
     $ xgensum -i <pkgname>
 
+### Adopting a template
+
+If a template is orphaned (maintained by `orphan@voidlinux.org`) or the current `maintainer` has not contributed to
+Void in over a year, template maintainership can be adopted by someone else. To ensure a template gets the care it needs,
+template adopters should be familiar with the package and have an established history of contributions to Void.
+Those who have contributed several updates, especially for the template in question, are good candidates for template
+maintainership.
+
+It is best to adopt a template when making another change to it. When adopting the template, add your name or username
+and email to the `maintainer` field in the template, and mention the adoption in your commit message, for example:
+
+    libfoo: update to 1.2.3, adopt.
+
+### Orphaning a template
+
+If you no longer wish to maintain a template, you can remove yourself as maintainer by setting the `maintainer` field in
+the template to `Orphaned <orphan@voidlinux.org>`. The commit message should mention this, for example:
+
+    libfoo: orphan.
+
+It is not necessary to make other changes to the template when orphaning, and incrementing the revision (triggering a
+rebuild) is not necessary either.
+
 ### Committing your changes
 
 After making your changes, please check that the package builds successfully. From the top level directory of your local copy of the `void-packages` repository, run:

Re: [PR PATCH] [Merged]: [RFC] CONTRIBUTING.md: describe adoption/orphaning policy and procedure

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

There's a merged pull request on the void-packages repository

[RFC] CONTRIBUTING.md: describe adoption/orphaning policy and procedure
https://github.com/void-linux/void-packages/pull/45207

Description:
I think it would be good to codify some of this. Open to suggestions on everything.

@void-linux/pkg-committers