Github messages for voidlinux
 help / color / mirror / Atom feed
From: MeganerdNL <MeganerdNL@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: encrypted-dns
Date: Wed, 02 Aug 2023 07:35:20 +0200	[thread overview]
Message-ID: <20230802053520.m_CEZg3k6TxGzamXvWxwpUl-GZbDEEb4mAxaXQ5aiGA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-45381@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

New review comment by MeganerdNL on void-packages repository

https://github.com/void-linux/void-packages/pull/45381#discussion_r1281415309

Comment:
> don't vendor this file, grab it from the builddir in post_install

I can do that, actually did it at first when creating this but then decided this (saw some other packages do it).

Is it ok to change (or add in) some values like _user/group_ in the example config via _vsed_  in the template to accommodate? I have the code here already.

  parent reply	other threads:[~2023-08-02  5:35 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-02  5:14 [PR PATCH] " MeganerdNL
2023-08-02  5:28 ` [PR REVIEW] " classabbyamp
2023-08-02  5:28 ` classabbyamp
2023-08-02  5:28 ` classabbyamp
2023-08-02  5:28 ` classabbyamp
2023-08-02  5:28 ` classabbyamp
2023-08-02  5:28 ` classabbyamp
2023-08-02  5:35 ` MeganerdNL [this message]
2023-08-02 12:15 ` MeganerdNL
2023-08-02 12:16 ` MeganerdNL
2023-08-04  7:48 ` MeganerdNL
2023-08-04  9:33 ` [PR PATCH] [Updated] " MeganerdNL
2023-08-04  9:37 ` MeganerdNL
2023-08-04  9:40 ` [PR REVIEW] " MeganerdNL
2023-08-04  9:41 ` MeganerdNL
2023-08-04  9:41 ` MeganerdNL
2023-08-04  9:41 ` MeganerdNL
2023-08-04  9:42 ` MeganerdNL
2023-08-04  9:43 ` [PR PATCH] [Updated] " MeganerdNL
2023-08-04  9:59 ` MeganerdNL
2023-08-04 12:58 ` [PR REVIEW] " classabbyamp
2023-08-04 12:58 ` classabbyamp
2023-08-04 12:58 ` classabbyamp
2023-08-04 12:58 ` classabbyamp
2023-08-04 12:58 ` classabbyamp
2023-08-04 18:08 ` [PR PATCH] [Updated] " MeganerdNL
2023-08-04 18:17 ` MeganerdNL
2023-08-04 18:18 ` MeganerdNL
2023-08-04 18:22 ` MeganerdNL
2023-08-04 18:29 ` MeganerdNL
2023-08-04 18:41 ` MeganerdNL
2023-08-04 18:51 ` [PR REVIEW] " classabbyamp
2023-08-04 18:57 ` MeganerdNL
2023-08-04 19:01 ` [PR REVIEW] " MeganerdNL
2023-08-04 19:01 ` MeganerdNL
2023-08-04 19:20 ` classabbyamp
2023-08-04 20:52 ` MeganerdNL
2023-08-11  8:52 ` [PR PATCH] [Updated] " MeganerdNL
2023-08-11  8:53 ` MeganerdNL
2023-09-02 15:27 ` MeganerdNL
2023-09-02 15:31 ` MeganerdNL
2023-09-02 18:09 ` Duncaen
2023-09-02 19:12 ` MeganerdNL
2023-09-02 19:53 ` Duncaen
2023-09-02 22:11 ` MeganerdNL
2023-09-03 11:26 ` Duncaen
2023-09-03 11:26 ` Duncaen
2023-09-03 20:47 ` [PR PATCH] [Updated] " MeganerdNL
2023-09-03 20:57 ` MeganerdNL
2023-09-03 20:58 ` MeganerdNL
2023-09-15 10:08 ` [PR PATCH] [Updated] " MeganerdNL
2023-12-15  1:46 ` github-actions
2023-12-30  1:45 ` [PR PATCH] [Closed]: " github-actions

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230802053520.m_CEZg3k6TxGzamXvWxwpUl-GZbDEEb4mAxaXQ5aiGA@z \
    --to=meganerdnl@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).