Github messages for voidlinux
 help / color / mirror / Atom feed
From: ethamck <ethamck@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: wiki-tui-0.8.1
Date: Thu, 10 Aug 2023 01:57:42 +0200	[thread overview]
Message-ID: <20230809235742.S-6vByJ1JzwfbkkhBDAXBT8g4EjUqxDExb0Nb-Jszhg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-45438@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 995 bytes --]

New comment by ethamck on void-packages repository

https://github.com/void-linux/void-packages/pull/45438#issuecomment-1672333762

Comment:
I'm currently waiting for a version bump in the main repository to do this.

Previously, the icon that would be bundled with the desktop file was an unscalable raster of an odd size, so I opened [#207](https://github.com/Builditluc/wiki-tui/issues/207). The next version published will include proper icon sizes.

I have some code locally that I assume will work perfectly once this happens, and if it does I'll force-push when tested.

```
diff --git a/srcpkgs/wiki-tui/template b/srcpkgs/wiki-tui/template
index 1a9630412a..24d4398b60 100644
--- a/srcpkgs/wiki-tui/template
+++ b/srcpkgs/wiki-tui/template
@@ -15,4 +15,7 @@ checksum=3fc11a53707531d658f47c04b1e148ff81332e20ada71f028c5c5cc69c2728aa
 
 post_install() {
        vlicense LICENSE
+
+       vcopy icons/ usr/share/icons/
+       vinstall wiki-tui.desktop 644 usr/share/applications
 }
```


  parent reply	other threads:[~2023-08-09 23:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-05 18:46 [PR PATCH] " ethamck
2023-08-06  3:25 ` classabbyamp
2023-08-09 23:57 ` ethamck [this message]
2023-08-09 23:59 ` ethamck
2023-08-12 14:13 ` [PR PATCH] [Updated] " ethamck
2023-08-12 22:12 ` [PR PATCH] [Updated] New package: wiki-tui-0.8.2 ethamck
2023-08-13  1:29 ` ethamck
2023-08-14  5:15 ` [PR PATCH] [Merged]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230809235742.S-6vByJ1JzwfbkkhBDAXBT8g4EjUqxDExb0Nb-Jszhg@z \
    --to=ethamck@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).