From: yoshiyoshyosh <yoshiyoshyosh@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: ufw: update to 0.36.2.
Date: Sat, 12 Aug 2023 08:04:41 +0200 [thread overview]
Message-ID: <20230812060441.DHT6swRdaub3OlG7f3PxNSTTtg65eAzuVhX3QR-jaPk@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-45559@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]
New comment by yoshiyoshyosh on void-packages repository
https://github.com/void-linux/void-packages/pull/45559#issuecomment-1675728394
Comment:
apologies for forgetting testing before PRing. fixed the current failing build by adding `./run-tests.sh` as `do_check`, but more test failures arise from doing that:
```
======================================================================
ERROR: test__get_defaults (tests.unit.test_backend_iptables.BackendIptablesTestCase.test__get_defaults)
Test _get_defaults()
----------------------------------------------------------------------
Traceback (most recent call last):
File "/builddir/ufw-0.36.2/tests/unit/test_backend_iptables.py", line 39, in setUp
shutil.copytree(d, d + ".bak")
File "/usr/lib/python3.11/shutil.py", line 559, in copytree
with os.scandir(src) as itr:
^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/builddir/ufw-0.36.2/tests/unit/tmp/ufw/lib/ufw'
... (for a lot more tests)
```
not sure what to do about this--`ufw.common.state_dir` & `ufw.common.config_dir` rely on `real_{state,config}_dir` from `setup.py`, which gets changed by `vsed`. even if this were fixed, there's other failing tests because some rely on `sysctl`'s existence. probably might be best to disable `do_check`
next prev parent reply other threads:[~2023-08-12 6:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-12 5:23 [PR PATCH] " yoshiyoshyosh
2023-08-12 6:04 ` yoshiyoshyosh [this message]
2023-08-12 6:05 ` yoshiyoshyosh
2023-08-12 6:06 ` yoshiyoshyosh
2023-08-12 6:07 ` yoshiyoshyosh
2023-08-12 6:12 ` yoshiyoshyosh
2023-08-12 14:33 ` yoshiyoshyosh
2023-08-13 0:39 ` [PR PATCH] [Updated] " yoshiyoshyosh
2023-08-13 0:44 ` yoshiyoshyosh
2023-08-13 0:44 ` yoshiyoshyosh
2023-08-20 14:30 ` [PR PATCH] [Merged]: " Duncaen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230812060441.DHT6swRdaub3OlG7f3PxNSTTtg65eAzuVhX3QR-jaPk@z \
--to=yoshiyoshyosh@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).