Github messages for voidlinux
 help / color / mirror / Atom feed
From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] [RFC] base-minimal: rename to base-container
Date: Sat, 12 Aug 2023 19:33:48 +0200	[thread overview]
Message-ID: <20230812173348.qzroAgz7thpD9qKjyajGs3zGe3kzq5CzUZpQevTXl70@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-45565@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 718 bytes --]

There is an updated pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages base-container
https://github.com/void-linux/void-packages/pull/45565

[RFC] base-minimal: rename to base-container
If we don't want to do this, I'd be fine with just changing the description.

This makes it more clear that it's not meant for normal usage. Provide a transitional package because this could ruin someone's day.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**



A patch file from https://github.com/void-linux/void-packages/pull/45565.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-base-container-45565.patch --]
[-- Type: text/x-diff, Size: 1842 bytes --]

From a0fb85ca520e3272e9a5cf875894f376611bd6b7 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Sat, 12 Aug 2023 13:22:02 -0400
Subject: [PATCH] base-minimal: rename to base-container

This makes it more clear that it's not meant for normal usage.
provide a transitional package because this could ruin someone's day
---
 srcpkgs/{base-minimal => base-container}/template | 14 ++++++++++----
 srcpkgs/base-minimal                              |  1 +
 2 files changed, 11 insertions(+), 4 deletions(-)
 rename srcpkgs/{base-minimal => base-container}/template (59%)
 create mode 120000 srcpkgs/base-minimal

diff --git a/srcpkgs/base-minimal/template b/srcpkgs/base-container/template
similarity index 59%
rename from srcpkgs/base-minimal/template
rename to srcpkgs/base-container/template
index f43f0c3ccc356..3778e3ae956bb 100644
--- a/srcpkgs/base-minimal/template
+++ b/srcpkgs/base-container/template
@@ -1,9 +1,9 @@
-# Template file for 'base-minimal'
-pkgname=base-minimal
+# Template file for 'base-container'
+pkgname=base-container
 version=0.3
-revision=1
+revision=2
 build_style=meta
-short_desc="Void Linux base system meta with minimal tools"
+short_desc="Void Linux base system meta for minimal containers/chroots"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="Public Domain"
 homepage="https://www.voidlinux.org/"
@@ -17,3 +17,9 @@ case "$XBPS_TARGET_MACHINE" in
 	*-musl) depends+=" musl";;
 	*) depends+=" glibc-locales";;
 esac
+
+base-minimal_package() {
+	depends="${sourcepkg}>=${version}_${revision}"
+	short_desc+=" (transitional dummy package)"
+	build_style=meta
+}
diff --git a/srcpkgs/base-minimal b/srcpkgs/base-minimal
new file mode 120000
index 0000000000000..4b836ce798602
--- /dev/null
+++ b/srcpkgs/base-minimal
@@ -0,0 +1 @@
+base-container
\ No newline at end of file

  reply	other threads:[~2023-08-12 17:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-12 17:24 [PR PATCH] " classabbyamp
2023-08-12 17:33 ` classabbyamp [this message]
2023-08-12 17:37 ` ahesford
2023-08-12 17:42 ` [PR PATCH] [Updated] " classabbyamp
2023-08-12 17:43 ` [PR PATCH] [Updated] [RFC] base-{minimal,voidstrap}: rename to base-container{,-full} classabbyamp
2023-08-12 17:46 ` classabbyamp
2023-08-12 17:48 ` classabbyamp
2023-08-14 11:56 ` Zapeth
2023-08-14 12:03 ` Zapeth
2023-08-14 12:03 ` Zapeth
2023-08-14 13:42 ` ahesford
2023-08-14 14:07 ` Zapeth
2023-11-13  1:46 ` github-actions
2023-11-30 15:13 ` [PR PATCH] [Updated] " classabbyamp
2023-12-01 23:15 ` [PR PATCH] [Merged]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230812173348.qzroAgz7thpD9qKjyajGs3zGe3kzq5CzUZpQevTXl70@z \
    --to=classabbyamp@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).