Re: [PR PATCH] [Updated] metalog: fix bleeding logs onto tty1

[shahab-vahedi <shahab-vahedi@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

There is an updated pull request by shahab-vahedi against master on the void-packages repository

https://github.com/shahab-vahedi/void-packages fix-metalog-bleeding
https://github.com/void-linux/void-packages/pull/45700

metalog: fix bleeding logs onto tty1
This fixes issue #45653 [1].

[1]
https://github.com/void-linux/void-packages/issues/45653

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture: x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/45700.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-metalog-bleeding-45700.patch --]
[-- Type: text/x-diff, Size: 1323 bytes --]

From 29cb35175ff0fdf92ecad7a2bf7faadcd0123223 Mon Sep 17 00:00:00 2001
From: Shahab Vahedi <shahabvahedi@gmail.com>
Date: Mon, 21 Aug 2023 13:46:03 +0200
Subject: [PATCH] metalog: fix bleeding logs onto tty1

This fixes issue #45653 [1]. There are 2 changes involved:

1. Drop the verbosity.
2. Redirect stdout to void (pun intented).

This patch is practically Duncaen's suggestion.

[1]
https://github.com/void-linux/void-packages/issues/45653
---
 srcpkgs/metalog/files/metalog/run | 4 +---
 srcpkgs/metalog/template          | 2 +-
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/metalog/files/metalog/run b/srcpkgs/metalog/files/metalog/run
index 5b7ff14eba605..04b457baae764 100755
--- a/srcpkgs/metalog/files/metalog/run
+++ b/srcpkgs/metalog/files/metalog/run
@@ -1,5 +1,3 @@
 #!/bin/sh
-exec 2>&1
-exec 1>&2
 [ -r conf ] && . ./conf
-exec metalog ${OPTS=-v}
+exec metalog ${OPTS} >/dev/null
diff --git a/srcpkgs/metalog/template b/srcpkgs/metalog/template
index 1f1a4c5c9496f..ed5e4435a6213 100644
--- a/srcpkgs/metalog/template
+++ b/srcpkgs/metalog/template
@@ -1,7 +1,7 @@
 # Template file for 'metalog'
 pkgname=metalog
 version=20230719
-revision=1
+revision=2
 build_style=gnu-configure
 conf_files="/etc/metalog.conf"
 hostmakedepends="autoconf autoconf-archive automake pkg-config"