Github messages for voidlinux
 help / color / mirror / Atom feed
From: the-maldridge <the-maldridge@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Closed]: go: update to 1.21.0.
Date: Wed, 23 Aug 2023 23:33:19 +0200	[thread overview]
Message-ID: <20230823213319.OgSlwUx9hPfkv4MDn9ut1GV6447s4rK_QuDdVz23Ce4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-45525@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1159 bytes --]

There's a closed pull request on the void-packages repository

go: update to 1.21.0.
https://github.com/void-linux/void-packages/pull/45525

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

- I built this PR locally for my native architecture, (amd64)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - i686
  - aarch64
  - armv7l

This version update has patch files changes, because sources were changed. I tested it with `./xbps-src check go`.

Also `do_isntall` script changed because go binary is built with `-trimpath` option since 1.21 version, see https://github.com/golang/go/issues/61921#issuecomment-1673399370. It's recommended to use symlinks for `/usr/big/go` instead of copying binaries:
> is there a reason your script is using cp to make copies of the binaries in GOROOT/bin, instead of using ln to make /usr/bin/go a symbolic link? It seems like that would be a simpler solution, and would allow the Go toolchain installed on Void Linux to use the same [reproducible binaries](https://go.dev/rebuild) that are distributed through the Go project.

[ci skip]

  parent reply	other threads:[~2023-08-23 21:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-10 18:10 [PR PATCH] " g4s8
2023-08-10 18:24 ` g4s8
2023-08-11 11:54 ` mhmdanas
2023-08-12 15:42 ` [PR PATCH] [Updated] " g4s8
2023-08-12 15:47 ` g4s8
2023-08-12 16:33 ` g4s8
2023-08-12 21:15 ` g4s8
2023-08-12 21:27 ` Bnyro
2023-08-13  8:03 ` paper42
2023-08-14 15:39 ` [PR PATCH] [Updated] " g4s8
2023-08-14 15:42 ` g4s8
2023-08-14 16:01 ` mhmdanas
2023-08-14 21:11 ` [PR PATCH] [Updated] " g4s8
2023-08-21  6:18 ` g4s8
2023-08-22  7:28 ` g4s8
2023-08-22  7:29 ` g4s8
2023-08-23  8:13 ` [PR PATCH] [Updated] " g4s8
2023-08-23 21:33 ` the-maldridge [this message]
2023-12-02 21:58 ` dkwo
2023-12-02 22:01 ` dkwo
2023-12-07 10:22 ` g4s8
2023-12-07 15:01 ` dkwo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230823213319.OgSlwUx9hPfkv4MDn9ut1GV6447s4rK_QuDdVz23Ce4@z \
    --to=the-maldridge@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).